Overview
| Comment: | notify: extract shared natshdr.Carrier to kill duplicate header-carrier
Two copies of natsHeaderCarrier existed (leaf/agent/nats.go and leaf/agent/notify/pubsub.go), both carrying the same latent case-sensitive Get bug that was fixed in Task 6. Extract the type to leaf/agent/internal/natshdr so the next bug can be fixed once. While consolidating, drop the 4-tier fallback in Get in favor of a single EqualFold scan. Header maps are tiny (typically 3 entries) and tiers 1-3 were subsumed by tier 4 anyway. The new implementation is demonstrably correct and easier to read. |
|---|---|
| Timelines: | family | trunk | leaf/v0.0.2 |
| Files: | files | file ages | folders |
| SHA3-256: |
b53032d01f9b8f9d1b7a3df40a75e4aa |
| User & Date: | [email protected] on 2026-04-24 16:02:07.000 |
| Other Links: | manifest | tags |
Context
|
2026-04-24
| ||
| 16:02 |
notify: extract shared natshdr.Carrier to kill duplicate header-carrier
Two copies of natsHeaderCarrier existed (leaf/agent/nats.go and leaf/agent/notify/pubsub.go), both carrying the same latent case-sensitive Get bug that was fixed in Task 6. Extract the type to leaf/agent/internal/natshdr so the next bug can be fixed once. While consolidating, drop the 4-tier fallback in Get in favor of a single EqualFold scan. Header maps are tiny (typically 3 entries) and tiers 1-3 were subsumed by tier 4 anyway. The new implementation is demonstrably correct and easier to read. check-in: b53032d01f user: [email protected] tags: trunk, leaf/v0.0.2 | |
Changes
Added .claude/README.md version [ca2bcef331].
Added .claude/settings.json version [720770da92].
Added .claude/skills/gitnexus/gitnexus-cli/SKILL.md version [f6c2bf7113].
Added .claude/skills/gitnexus/gitnexus-debugging/SKILL.md version [cdd227de56].
Added .claude/skills/gitnexus/gitnexus-exploring/SKILL.md version [b5b9237dfe].
Added .claude/skills/gitnexus/gitnexus-guide/SKILL.md version [269f2b61f3].
Added .claude/skills/linear-cli/SKILL.md version [7a0c96f9d0].
Added .claude/skills/linear-cli/SKILL.template.md version [e4e45f1c6c].
Added .claude/skills/linear-cli/references/api.md version [46f2d48f78].
Added .claude/skills/linear-cli/references/auth.md version [ffcf603cf9].
Added .claude/skills/linear-cli/references/commands.md version [ede99344e3].
Added .claude/skills/linear-cli/references/config.md version [8ff9113fa4].
Added .claude/skills/linear-cli/references/cycle.md version [ce9045f045].
Added .claude/skills/linear-cli/references/document.md version [76cbce86c9].
Added .claude/skills/linear-cli/references/initiative.md version [90b111fdfa].
Added .claude/skills/linear-cli/references/issue.md version [243a79fb53].
Added .claude/skills/linear-cli/references/label.md version [8e16a3cd85].
Added .claude/skills/linear-cli/references/milestone.md version [cfcf99ad27].
Added .claude/skills/linear-cli/references/project.md version [ecdcc3a99b].
Added .claude/skills/linear-cli/references/schema.md version [cf10a2675a].
Added .claude/skills/linear-cli/references/team.md version [09da3cc926].
Added .claude/skills/linear-cli/scripts/generate-docs.ts version [4148c7fe84].
Added .claude/skills/tigerstyle/SKILL.md version [04d13f2443].
Added .dockerignore version [3bc5ddec7f].
Added .envrc version [da1fd2003a].
Added .githooks/pre-commit version [92defb82cb].
Added .github/workflows/ci.yml version [1c17eb8f45].
Added .github/workflows/test.yml version [cd752e6af9].
Added .gitignore version [824a6b8ae3].
Added .mcp.json version [ed27c0fcf6].
Added CLAUDE.md version [6f7e0ac818].
Added MEMORY.md version [ebbdd53404].
Added Makefile version [6dca0e55a5].
Added README.md version [bdac26335c].
Added bridge/bridge/bridge.go version [cd561aa490].
Added bridge/bridge/bridge_test.go version [a13fb5af49].
Added bridge/bridge/config.go version [3dfd9c735b].
Added bridge/bridge/integration_test.go version [f1591b01a2].
Added bridge/cmd/bridge/main.go version [df14f34662].
Added bridge/go.mod version [01a7d3f25c].
Added bridge/go.sum version [daead7f01c].
Added cmd/edgesync/bridge_serve.go version [0f474f082d].
Added cmd/edgesync/cli.go version [5a8e37ea7f].
Added cmd/edgesync/doctor.go version [70635f3678].
Added cmd/edgesync/main.go version [f41602185e].
Added cmd/edgesync/notify.go version [7e0daf7ecb].
Added cmd/edgesync/notify_test.go version [e18656cbfb].
Added cmd/edgesync/sync_now.go version [029f54ddb4].
Added cmd/edgesync/sync_start.go version [3b3cfa08b7].
Added deploy/Dockerfile version [57dba27d7b].
Added deploy/docker-compose.yml version [d86fe3fb66].
Added deploy/nats.conf version [022b510156].
Added docs/GETTING-STARTED.md version [8c998decfd].
Added docs/architecture/agent-deployment.md version [95b0d535fc].
Added docs/architecture/checkout-merge.md version [35e63f09f4].
Added docs/architecture/core-library.md version [4c742b0344].
Added docs/architecture/notify-messaging.md version [5473344821].
Added docs/architecture/repo-operations.md version [25059fdf64].
Added docs/architecture/sync-protocol.md version [fe3dd37b15].
Added docs/architecture/testing-strategy.md version [ab3c7f3099].
Added docs/bridge.md version [5109328636].
Added docs/leaf-agent.md version [ff4974a0a4].
Added docs/superpowers/plans/2026-04-08-nats-over-iroh.md version [1198181149].
Added go.mod version [58c6eb94bd].
Added go.sum version [20f4bb0617].
Added go.work.example version [76e72e0164].
Added iroh-sidecar/.gitignore version [2f4601a020].
Added iroh-sidecar/Cargo.lock version [71a7565ccf].
Added iroh-sidecar/Cargo.toml version [f9d163453e].
Added iroh-sidecar/src/acceptor.rs version [5977a83606].
Added iroh-sidecar/src/endpoint.rs version [ba7699d115].
Added iroh-sidecar/src/main.rs version [31b45343a9].
Added iroh-sidecar/src/server.rs version [545bed2170].
Added iroh-sidecar/src/tunnel.rs version [5b99b87609].
Added leaf/agent/agent.go version [53fd08d99b].
Added leaf/agent/agent_test.go version [1149833cb6].
Added leaf/agent/autosync.go version [3a6f960952].
Added leaf/agent/autosync_test.go version [51c83ad548].
Added leaf/agent/clientid.go version [2af07c6ba3].
Added leaf/agent/config.go version [76a6168647].
Added leaf/agent/integration_test.go version [5f1aeff4a5].
Added leaf/agent/internal/natshdr/carrier.go version [8b3806e7a2].
Added leaf/agent/internal/natshdr/carrier_test.go version [97d84526bf].
Added leaf/agent/iroh.go version [17216ecaaf].
Added leaf/agent/iroh_test.go version [a40389a593].
Added leaf/agent/nats.go version [2e1850529c].
Added leaf/agent/nats_mesh.go version [2731415a6f].
Added leaf/agent/nats_mesh_test.go version [4e1af73f8b].
Added leaf/agent/nats_test.go version [9a09dfd972].
Added leaf/agent/notify/device_registry.go version [7b21515072].
Added leaf/agent/notify/device_registry_test.go version [406244c228].
Added leaf/agent/notify/message.go version [0c27cb5750].
Added leaf/agent/notify/message_test.go version [59f5833508].
Added leaf/agent/notify/notify.go version [ea814468bf].
Added leaf/agent/notify/notify_test.go version [a992913b36].
Added leaf/agent/notify/pubsub.go version [c1719a9538].
Added leaf/agent/notify/pubsub_test.go version [ee4180795e].
Added leaf/agent/notify/pubsub_traceparent_test.go version [58a0ceea75].
Added leaf/agent/notify/store.go version [83393a3e96].
Added leaf/agent/notify/store_test.go version [233d3a2c44].
Added leaf/agent/notify/token.go version [91cbc2cbe0].
Added leaf/agent/notify/token_store.go version [3cd2ccca01].
Added leaf/agent/notify/token_store_test.go version [124ec8a01b].
Added leaf/agent/notify/token_test.go version [f0719b284a].
Added leaf/agent/notify_integration_test.go version [8c3ab2f600].
Added leaf/agent/peer_registry.go version [f56f856f2f].
Added leaf/agent/peer_registry_test.go version [54268f5657].
Added leaf/agent/serve_http.go version [00fb6e52dd].
Added leaf/agent/serve_http_test.go version [33def963ef].
Added leaf/agent/serve_nats.go version [87e61dab7c].
Added leaf/agent/serve_p2p.go version [05ad1a7ebf].
Added leaf/agent/sidecar.go version [2870b36943].
Added leaf/agent/sidecar_test.go version [b60d215af3].
Added leaf/cmd/leaf/main.go version [9ccfa3796f].
Added leaf/cmd/wasm/main.go version [6a6e81c03d].
Added leaf/cmd/wasm/worker.js version [38d097b5db].
Added leaf/go.mod version [4e4774a4ef].
Added leaf/go.sum version [bd709d4c07].
Added leaf/telemetry/cache_metrics.go version [f8fe78f94e].
Added leaf/telemetry/cache_metrics_noop.go version [512931bcce].
Added leaf/telemetry/checkout_observer.go version [481a867f57].
Added leaf/telemetry/checkout_observer_noop.go version [c4a1e1e3cc].
Added leaf/telemetry/ctxslog.go version [25c049729a].
Added leaf/telemetry/ctxslog_test.go version [bb04f5c09e].
Added leaf/telemetry/noop.go version [57200e1c82].
Added leaf/telemetry/observer.go version [40fc3f31ed].
Added leaf/telemetry/observer_test.go version [9d3259e09c].
Added leaf/telemetry/setup.go version [d919c5d0fb].
Added leaf/telemetry/setup_test.go version [25d5355bc8].
Added leaf/telemetry/verbose.go version [78b9a0e1a6].
Added leaf/telemetry/verbose_test.go version [0f38c85da4].
Added leaf/wsdialer/conn.go version [ce53d72b81].
Added leaf/wsdialer/dialer.go version [4d69f9edd2].
Added sim/buggify.go version [da268bc023].
Added sim/buggify_test.go version [9251839482].
Added sim/checkout_test.go version [9251839482].
Added sim/cmd/soak/main.go version [159da7dd4f].
Added sim/config.go version [93ed2e3b21].
Added sim/diff_interop_test.go version [9251839482].
Added sim/equivalence_test.go version [9251839482].
Added sim/finfo_interop_test.go version [9251839482].
Added sim/harness.go version [6d200abc17].
Added sim/interop_test.go version [9251839482].
Added sim/invariants.go version [d98dfde2a6].
Added sim/iroh_test.go version [79fd43a190].
Added sim/nats_iroh_test.go version [31ffea9a05].
Added sim/otel_test.go version [9251839482].
Added sim/proxy.go version [3f9fc38d15].
Added sim/proxy_test.go version [9251839482].
Added sim/rebuild_test.go version [9251839482].
Added sim/schedule.go version [1d9f957c99].
Added sim/schedule_test.go version [9251839482].
Added sim/seed.go version [eae4002753].
Added sim/serve_test.go version [9251839482].
Added sim/shun_test.go version [9251839482].
Added sim/sim_test.go version [9251839482].
Added sim/uv_test.go version [9251839482].
Added testdata/fossil.fossil-shm version [9ebc781520].
Added testdata/fossil.fossil-wal version [a7ffc6f8bf].