Skip to content
zit Artifact [d9578c6c6e]
Login

Artifact [d9578c6c6e]

Artifact d9578c6c6e2491bf78828dccb3489f09d56eb720b5f1d4e5735d4879beac7a71:

Manifest of check-in [d9578c6c6e] - shun: whole-branch verification fixes

Read as one change rather than eight slices, which surfaced defects no per-slice review could see.

A peer could crash us. ShunSet.contains asserted its key domain while its own vtable contract promised an out-of-domain name answers false and never traps -- and a 'file HASH zz SIZE' card reached it. It is a checked rejection now, and receiveDelta refuses a DELTASRC that is not a complete artifact name before one can mint a phantom, which also closes a pre-existing PendingDeltaQueue trap on the same card.

Two rewrites could un-shun each other. rewriteAndSwap's pre-rename guard re-stat'ed the caller's handle, which after a competing rename points at the old inode -- so the guard passed and the loser silently reverted the winner. It reopens .zit by name under the temp lock now, as shunAppendRows already did.

The client snapshot lacked the masked-basis guard the serve path has, so a kept delta rooted on a shunned base could be handed out in delta form.

shun_help denied two slices that landed after it was written: it still told operators a shunned artifact is only suppressed in one direction and can be re-announced back into the store.

Also: storestat's shun rows and bytes are wired into zit stat rather than left unused, so the printed breakdown still sums to the file size; the clone-send half is relabelled an erratum candidate against SS8.1/SS8.2 instead of claiming SS9.5, which is scoped to non-clone; and three stale doc bullets now describe the code that exists. by dmestas on 2026-07-30 18:32:25.


C shun:\swhole-branch\sverification\sfixes\n\nRead\sas\sone\schange\srather\sthan\seight\sslices,\swhich\ssurfaced\sdefects\sno\nper-slice\sreview\scould\ssee.\n\nA\speer\scould\scrash\sus.\sShunSet.contains\sasserted\sits\skey\sdomain\swhile\sits\sown\nvtable\scontract\spromised\san\sout-of-domain\sname\sanswers\sfalse\sand\snever\straps\s--\nand\sa\s'file\sHASH\szz\sSIZE'\scard\sreached\sit.\sIt\sis\sa\schecked\srejection\snow,\sand\nreceiveDelta\srefuses\sa\sDELTASRC\sthat\sis\snot\sa\scomplete\sartifact\sname\sbefore\sone\ncan\smint\sa\sphantom,\swhich\salso\scloses\sa\spre-existing\sPendingDeltaQueue\strap\son\nthe\ssame\scard.\n\nTwo\srewrites\scould\sun-shun\seach\sother.\srewriteAndSwap's\spre-rename\sguard\nre-stat'ed\sthe\scaller's\shandle,\swhich\safter\sa\scompeting\srename\spoints\sat\sthe\nold\sinode\s--\sso\sthe\sguard\spassed\sand\sthe\sloser\ssilently\sreverted\sthe\swinner.\nIt\sreopens\s.zit\sby\sname\sunder\sthe\stemp\slock\snow,\sas\sshunAppendRows\salready\sdid.\n\nThe\sclient\ssnapshot\slacked\sthe\smasked-basis\sguard\sthe\sserve\spath\shas,\sso\sa\skept\ndelta\srooted\son\sa\sshunned\sbase\scould\sbe\shanded\sout\sin\sdelta\sform.\n\nshun_help\sdenied\stwo\sslices\sthat\slanded\safter\sit\swas\swritten:\sit\sstill\stold\noperators\sa\sshunned\sartifact\sis\sonly\ssuppressed\sin\sone\sdirection\sand\scan\sbe\nre-announced\sback\sinto\sthe\sstore.\n\nAlso:\sstorestat's\sshun\srows\sand\sbytes\sare\swired\sinto\szit\sstat\srather\sthan\sleft\nunused,\sso\sthe\sprinted\sbreakdown\sstill\ssums\sto\sthe\sfile\ssize;\sthe\sclone-send\nhalf\sis\srelabelled\san\serratum\scandidate\sagainst\sSS8.1/SS8.2\sinstead\sof\sclaiming\nSS9.5,\swhich\sis\sscoped\sto\snon-clone;\sand\sthree\sstale\sdoc\sbullets\snow\sdescribe\nthe\scode\sthat\sexists.
D 2026-07-30T18:32:25.408
F .fossil-settings/ignore-glob 1e7a8c10ad58e9784eb011bcc04beb837ad043d54285d340040fae68baf34f86
F .github/workflows/ci.yml 7b817b4a7c230e3f351a112a83c0cad98db79add99264a07549cab8d499120f9
F LICENSE 702ae7ff835a2a971dae11c5cae039803bf394b77a6d8ec9f18693e449eaaf26
F README.md 67bb1afa5bff033e7ce51ff92e782a8a22a5e64541c219b338147da4b1ad8f47
F build.zig d8f7b820a7a98c3677515881b2c04e32c9de93ba7eff820f0c5c63df4b301626
F build.zig.zon dd3992bfc8da12e09a018c4697e38ddf79d07e225405af448ecca1ebefc3ea0c
F docs/RELEASE-NOTES-0.1.0.md 5ed8b4d35ee23b7990261f8af34f5fa3cc629baf63b0059d9f7bb2d2c48dc802
F docs/RELEASE-NOTES-0.1.1.md 59eea8c487dc1e9190c44c371656e430cd5621031a71c502ecbae96802712857
F docs/RELEASE-NOTES-0.1.2.md 7c968ab247ad1194f9163e625a37452ae72bdc23f3e66e8ea26b39f6e0a52914
F docs/RELEASE-NOTES-0.1.3.md c8f703b8717040f96a9b77ad132bbe309ba4368ead5362739e4d5ef23f2d3286
F docs/rfcs/draft-fossil-artifact-format-00.txt a6d542a5effeb41d0ea1e916058ccdc0a5819787f167ef1ebad7814f5680e7ad
F docs/rfcs/draft-fossil-delta-format-00.txt d8025d6d75322e33887c3334a4b9cc729960028b3c994ed01e5a474e4b388fd2
F docs/rfcs/draft-fossil-repo-state-00.txt b35480166caaf5d2c220086140a1d47034e9b4967689be8f4cd8779bbdbbc3da
F docs/rfcs/draft-fossil-sync-protocol-00.txt 153d31ec11ff6636793514df711389883d5dd3111b97d3da295a30308fb400b4
F scripts/mirror-export.sh cc1130129e3c320cb9c1c5a05f505e45ece23d6bb3e0228da8e7ffe97bd5612b x
F scripts/soak.README 3a2f028e4f87a395b2b779ac63260fcb68a7a9c7ffc9fea5b065d5bc065c4719
F scripts/soak.sh e184de2f7396ae88c1266d565092282dc9aff151fab8f971840d867562f7d1be x
F src/annotate.zig 0a6b6728099e63c84681d1e5228ebb45fafb55d65df1720358247fd6e6532c63
F src/artifact.zig c630afd9fbbcfaccd7b823105b4d05db1dc85b6af03080a6d58635ed064672ca
F src/artifact_fuzz.zig c28bf210176eec4ca7232f256187f00d273c3ecafe7ed2271eaca3bd15b748ba
F src/artifact_test.zig da999476660f7e6e1f50ed9da5c30f1c83d6b358e2cfcd265c6932959c85bdd1
F src/bisect.zig 70a0b3561380f216a0cea9ee9419bb1cd1b77d9b6a73786f41992dfd70ceb04a
F src/checkout.zig 31f20dc1fe5285575b7bfca7fedbca1dae07e2cb77c9fde6f0f27e72a7e4f80f
F src/ci_test.zig a75b83a94e7d28d11f9c73c0dfae450000e31ca9a7b7563f8120686112047c84
F src/cli.zig bf26e11c679be34921c1d46b11a6cc949cb150998f777643cb4f9b5684da400f
F src/cmd/checkout.zig b617e30e50addaffe550b17a701516a912b8f591aabb7431a602ea0532f57e15
F src/cmd/history.zig a69c22be0a669c60ae2294891b7a3acbb61b524f7e20f760b19e8aa893813579
F src/cmd/sync.zig 586f678b978cc227f6296d8e3c3ec64441441a56ffc714f33ab0db733a965f12
F src/cmd/tracking.zig 46b079b974838f92b9508a647c0a89e3747fec09dab072a0bae2c0d0639c4831
F src/container.zig cef1028531f2763f94248b761c8779a1884e44bb854b8c45617494e3ead40e61
F src/container_test.zig a013652b1ed181161d3ad8fc9d8f052f7c27b61e129662632ceaf8cf189445ec
F src/crc32.zig 57429c29f4a67a9bfaebad8d5826471f9ff26cfd085c5424bf8e0fccba376bb4
F src/crc32_fuzz.zig 2e6c3425989051ec826b0f1208fa9716808011e71c98ff0a5ae2e38de524caea
F src/delta.zig e8f3a6297d47549aea146222732ccf514c39688414f0a74ba396ac91066686f3
F src/delta_fuzz.zig 5e5c715722760d6f45c4eaaf9b5d495bf83c59e5869a0e0dd76bb57b007e3b53
F src/delta_test.zig b18d97e117dce8fbcc05bff6f6954effdb946bab6d36337efbe5ef64d10646a0
F src/dst.zig e7ef6c8ba396da771a145224e22dfc749250cee73ded1188bfe00eb3c27eca92
F src/e2e.zig 823e752815d808a40c6655ed2612df558dd25edfc50867597f250a4336aaf044
F src/extras.zig d7b6ec8caa95993ce01c4ed9ddd0cda327db823bdbde4e27dff4966591be25f5
F src/fuzz_tests.zig a324613efc60b71f7712a54c06ac074f98abbb95a106f5ea4415cb7f336923e4
F src/logstore.zig 99ee082a5f39227366e26901a9f7d0e45d7451e8e17d458c3ac93dc7ef1dda25
F src/logstore_benchmark.zig 1ce3cfb1eec19cdba9345ec432d01aa2e0f56dfb0ecae7c578638a3d60d9cfa8
F src/logstore_fuzz.zig 2f5a65a28aad0c2c8d053d941ba872f53e99414135309c82bf0a0b0efdf9e7b5
F src/logstore_test.zig 1e6218325cba9207f8c15f6fe962c6e38c6fb6e581a67d16c5bc0a0efbe07410
F src/main.zig baf7422012f2333a08c0d73d46a1a1d722e8e05cdd4b598f5509bda89adc7922
F src/managed.zig 81ccc2d6321fe3dff91f653305ae4e73bea0b3fae7db2ab2f0cf168d9518d601
F src/merge3.zig 7fc52445688751bb8af30462549650660bcdbadabef54d892b6505d628248d0b
F src/merge3_fuzz.zig 83dcd4d9f2f9c208baa15e79ceeea80a0ebf47456a9b045f6d1c1efe3a927582
F src/pack.zig 5c2aaf66d0f16ac7ec313b971957a6f89ce9578f8cb277b839bdea8bc33a9993
F src/packaging_test.zig 87e272e5a1487c035fe2f71463fa68006a04764cb7910f8acbb88805f9d4114f
F src/repocache.zig 32af5b54b011fef358a134273b5e6f43da4282122c05a85ad503a8f7796c6c66
F src/repoimage.zig 7d2dc2f3c145e10e2d9ba6997705fd61a0cc0aedde8e171c253163d1279ccdd5
F src/repository.zig bbf2d73a3dc76a23d25811f7d4c3ba5c7a92245808bf7aeac606d87c2e792f1d
F src/repository_test.zig 7ecff1b41d376285f4a9ea879bf53d6e9557efc77e52203ada40df9eabf35290
F src/repostate.zig 68432b54ad3db2a2723d13786073340edc47e3901c49f29bbc6bce6848e2cd57
F src/repostate_test.zig e5699688b0f43b7480ed5d89f11585c2f61114bbe3ec9dae5061741f37b37e7a
F src/repoview.zig b3eb611496da8f970fe1be46499474c5922e0161106483c3d360b3e2ad9a696d
F src/rfc_vectors/artifact_a1_1_sha1_manifest.txt 82d8fc78b3fbf85efe80cb05e79db40c910bf0551e55b728c6f9c2ca7a42ddb6
F src/rfc_vectors/artifact_a1_2_sha3_technote.txt 832e850f83aab2e2a754aa97591109f7f05fb41e4126c7e71c88a59d6d17e55d
F src/rfc_vectors/artifact_a3_rcard_manifest.txt 47e412ef211f095e93275fadf527909e581eef42357d8437fc7e299bfc3e62a7
F src/rfc_vectors/sync_a1_round1_reply.txt 638813029b10f81303b88859279afb17095d7c779c993f4267870909acabbeb9
F src/rfc_vectors/sync_a1_round2_file_cards.txt 4fa397741f7521cc4181d5d6b04dc143187f57602384eaa688552115ecda27c2
F src/rfc_vectors/sync_a1_round2_reply.txt af956808190c79b37a384041690c36b78845b471d6c6c01d1cced6e3ee92e6b1
F src/rfc_vectors/sync_a2_reply.txt aa130a127cde210f793c7842960083c765e0ffc7b673374fabc8f0edfe03d763
F src/root.zig 51b56763eb26715d5ebef4b118d0fdb8bf0c22f17aeb96249b84fa73964a9ffb
F src/serve.zig 58af81fdc580627839a84eacec7971459a1bd9accbdbe5434f504836f02981de
F src/serve_benchmark.zig ff55c6148e961c9374ad60a756d9d997fadbc854d2a79d625235b580aefb8656
F src/serve_fuzz.zig 3c39ea768ffa37599e2cc00c588f053870766ab91500aceb0d844a4322174687
F src/sim/assembly_sweep.zig 794ea5a1388c000ac7d2bca6706a784b2cd591d3adef2e879b54bfab261878cc
F src/sim/checkout_sweep.zig 80bb6fef67c88a29a2b6bdc372996c9f2c4ad65db289cddebc7a427b42ee5d39
F src/sim/faulty_dir.zig 35daf0603aca3093b88498b51feccad8297f85f49a5c9a7a9d61b02e834081f5
F src/sim/faulty_file.zig 720be41b7f9bd64b9fd2586201e2f62d79c6d60452196eedeb9708b170093424
F src/sim/gen.zig a05fa9fa17e4b585c662c6e1d3855e5e46327db9c7490bc834382b64e742c557
F src/sim/net.zig 8fb057012ce0a33f67c928cd696bc2761fea8ba4012b2daa33871b2ba5dfe772
F src/sim/oracle.zig bc9e272bb3332b7b715fbcc254b63583aa294b769d423f4be48593152717dfb2
F src/sim/shun_sweep.zig 8b7b2a106a9eaaeb4d041ec0faa061d51a8c2a866f8fcae5d245f814085b063d
F src/sim/storage_sweep.zig 97d7205161011af689aba27ba80c5280c9c347c45ec19068b82850d357d2772a
F src/sim/sync_gen.zig 238d46942915b5c0e989dfc738b5927b5228468ea123e6f17b6fb593aa5cbf6e
F src/sim/sync_sweep.zig a5069e059bdba0cb7ceac9395923a76e673944df67c5fd6d2c2b5db18483d376
F src/smoke.zig f92f9c0bca43eed62fde54e24b72cbd7b9a1f3071f5530d582fa0010cb4c20df
F src/storage.zig 512205eb629d5af8d50ad336f1ef49f53b455abd52ee2f9b56d20893cafad39f
F src/storage_benchmark.zig 9bc22dc2b683bd3924756979f0c2efa075429540ed23a80fec57327bb77b4890
F src/storestat.zig 3ba170b2f7f775474029e183908477169278841e6071ae085635213b70fb8400
F src/sync.zig b7f4efb71164052c62461104853ef04520b92cb244f2f2ab53884b0d0e132709
F src/sync_benchmark.zig f0d99a1f8273a1675a2f482a4977bbb12fc07a432447905c991bd359db73acdf
F src/sync_driver.zig 722ed498ea6b76900661a085d4257e51f6416d43ac1185e8ac15140de265f67e
F src/sync_driver_test.zig b50450d2938fc60aa90cd9067fc45141a965b63dc2194f42d5109919e380d7df
F src/sync_fuzz.zig 0ab9b7195535468db561cdcb405b7bf17536e2c6cb77a115ab1fe2badb001194
F src/sync_test.zig 089221f28748df8c5284e146c1ad4f48e468f93b31d43bd8121ee17ae1c55197
F src/tidy.zig c43465f253553b13e4b68f1c4e5eee3ec7638e2cd7ed8b4ce8dab4445bfb89d3
F src/transport.zig 36c4cbabaf10b30dbc20c6b8a30df94394a7e0a65b27613f0ace2f49ec1eaa79
F src/transport_fuzz.zig 43c310c51a6502fb2e049e6f43dfa151b1a632e6c885554ec6edce4ec62a8a48
F src/undo.zig c3ef95e4c6affeb893e60922506b760f483a6640fe3fd5c63bf86c6d20cf2675
F src/update.zig 743e89fa2a007ca980f23a55f26d14befe3635d387458a2b58b67edfa03ab65c
F src/update_test.zig c92b790daa737a1ba0b983c613de734d17028399fc303a8fd69298c3bc5325a1
F src/warmread_benchmark.zig 290887ab34f7777effcd4062c000456b1fcf8a59f84617a96a740d15a0245776
P cb22503707282b06028274500bb054593143e5a6f3362eaee0c55b7c6c55518b
R 53cca27724f60597123022585ca9b3ba
U dmestas
Z db953dbabe34cfd586ba357fdbea2d20