Artifact c7eb7decf1b4b3f40f619e353c4025fd1a97b96338d616f533b28125b89686a9:
- File
internal/index/branchcommits_test.go
-
2026-08-26 12:48:22
— part of check-in
[21fde3240d]
on branch landings-batch
— A landing's commits in ancestry order, not date order
The page listed the branch through the timeline, which orders by (date DESC, hash DESC). Two check-ins in the same second tie on date and then order by hash, which has nothing to do with which is the parent. Commits land back-to-back here routinely.
zit hit this in landing show and its fix is the one to inherit: the verb owns no ancestry ordering of its own. A recursive walk from the branch tip, ordered by longest path back, stopping where the branch diverges from its target.
The test commits three times in one second with hashes whose order is the reverse of ancestry — the old sort gets it exactly backwards and looks plausible doing it. (user: dmestas, size: 4596) [annotate] [blame] [check-ins using]
- 2026-08-26 12:58:43 — part of check-in [db0ed60824] on branch trunk — Accepted. Ordering by the DAG, one current landing per branch, and a verdict that was already an artifact. (user: dmestas, size: 4596) [annotate] [blame] [check-ins using]
-
2026-08-26 12:48:22
— part of check-in
[21fde3240d]
on branch landings-batch
— A landing's commits in ancestry order, not date order