Skip to content
quarry Artifact [555ea075d3]
Login

Artifact [555ea075d3]

Artifact 555ea075d3ecbacfb3ec0112d07d40234deb63ccf25267c7fc9f95233ebbea76:


package oltp

import (
	"fmt"
	"path/filepath"
	"testing"
	"time"
)

func runnerReq(addr, repo string, i int) SignOff {
	return SignOff{Agent: RunnerAskerPrefix + addr, Owner: "jva", Op: "ci.worker.token.new", Repo: repo,
		Input: fmt.Sprintf(`{"repo":%q,"label":"h%d"}`, repo, i), Summary: "s", Pickup: fmt.Sprintf("%064x", i+1)}
}

// LAPSED RUNNER REQUESTS ARE CLOSED IN THE DATABASE AND NEVER LISTED, SO
// A STRANGER CANNOT PUSH THE OWNER'S REAL REQUESTS OUT OF THE LIST; AND
// THEY DO NOT COUNT AGAINST THEIR ADDRESS.
func TestLapsedRunnerRequestsNeitherFillTheListNorCountAgainstTheAddress(t *testing.T) {
	db, err := Open(filepath.Join(t.TempDir(), "o.db"))
	if err != nil {
		t.Fatal(err)
	}
	defer db.Close()
	for i := 0; i < 60; i++ {
		if _, err := db.RequestSignOff(runnerReq(fmt.Sprintf("198.51.100.%d", i), "suit", i)); err != nil {
			t.Fatal(err)
		}
	}
	// One address holds twenty, the most an asker may.
	for i := 0; i < MaxPendingSignOffs; i++ {
		if _, err := db.RequestSignOff(runnerReq("203.0.113.7", "suit", 100+i)); err != nil {
			t.Fatal(err)
		}
	}
	old := time.Now().Add(-RunnerLife - time.Minute).UTC().Format(time.RFC3339)
	if _, err := db.w.Exec(`UPDATE signoff SET requested = ?`, old); err != nil {
		t.Fatal(err)
	}
	real, err := db.RequestSignOff(SignOff{Agent: "jva-bot", Owner: "jva", Op: "repo.delete", Repo: "suit", Input: "{}", Summary: "real"})
	if err != nil {
		t.Fatal(err)
	}
	// The address that held twenty lapsed ones may ask again.
	if _, err := db.RequestSignOff(runnerReq("203.0.113.7", "suit", 999)); err != nil {
		t.Errorf("FAIL: lapsed requests still count against their address: %v", err)
	}
	got, err := db.SignOffsFor("jva", 50)
	if err != nil {
		t.Fatal(err)
	}
	var ids []string
	for _, s := range got {
		ids = append(ids, s.ID)
		if s.ID != real.ID && s.Agent[:3] == "run" && s.Requested == old {
			t.Errorf("FAIL: a lapsed runner request is listed")
		}
	}
	if len(got) == 0 || got[0].ID != real.ID {
		t.Errorf("FAIL: the real request is not first of %d listed", len(got))
	}
	if len(got) != 2 {
		t.Errorf("FAIL: %d listed, want the real request and the one new runner request", len(got))
	}
	var open int
	if err := db.db.QueryRow(`SELECT count(*) FROM signoff WHERE state = 'pending' AND agent LIKE 'runner at %' AND requested = ?`, old).Scan(&open); err != nil || open != 0 {
		t.Errorf("FAIL: %d lapsed runner requests are still pending in the database (%v)", open, err)
	}
	if !t.Failed() {
		t.Log("ok")
	}
}