Artifact ed24db2826717e33cefba47aa9aa275ec14b389005e01e6367a2c8c6cd395c78:
- File
internal/sync/client.go
-
2026-10-24 00:57:36
— part of check-in
[82dae665dd]
on branch main
— fix(sync): ask for phantoms in hash order
buildGimmeCards ranged over the phantoms map, so each round's gimme cards came out in Go's randomised map order. When a round has more phantoms than mxPhantomReq allows, that also picked a random subset to ask for. A seeded simulation then could not replay the same wire, and the docs generator's engine.json (which records a pull's cards) changed between runs, failing the generated-docs check about one run in three.
Sort the phantom names before building the cards. Phantom sets are bounded by what the peer announced, so the sort is cheap next to the round trip. (user: [email protected], size: 70417) [annotate] [blame] [check-ins using]
-
2026-10-24 01:04:43
— part of check-in
[d40046f706]
on branch main
— Merge pull request #474 from danmestas/fix/deterministic-gimme
fix(sync): ask for phantoms in hash order (user: [email protected], size: 70417) [annotate] [blame] [check-ins using]
- 2026-10-24 01:44:46 — part of check-in [eb2fc856e5] on branch main — Merge branch 'main' into feat/horizon-names-seed-refusal (user: [email protected], size: 70417) [annotate] [blame] [check-ins using]
-
2026-10-24 00:57:36
— part of check-in
[82dae665dd]
on branch main
— fix(sync): ask for phantoms in hash order