Artifact Description [aef2f350ea]

Artifact aef2f350ea3b23c2629137504a2478fad5988287b6155ced6f7710c919b72d9a:

• File internal/sync/receive_pass.go
  • 2026-10-24 13:08:15 — part of check-in [eac16cf7ed] on branch main — fix(sync): bound basis-chain walks at the read depth

    Any pusher could hold the write lock about 30s per push with a two-delta cycle. The receive pass's basis-chain walks, and the horizon seed check's pending-row walk, ran to 1<<24 steps before giving up.

    All of them now stop at content.MaxDeltaChainDepth, the depth at which content.Expand stops, so no walk outlasts what a read could ever use. What crossing the bound means at each site:

    - chainEnd (rootOf, for a dangling delta being stored) keeps a visited set. A chain that loops is refused, as it was, but at the revisit rather than after 1<<24 steps. A chain longer than the bound returns errChainTooDeep. storeDeltaContent then stores the delta untracked: the push succeeds, as a push onto a chain between 16k and 16M deep always did, and since no basis can make the delta readable there is nothing to check against its name later. Storing matches the current behaviour, and an honest transfer never fails for a deep chain it did not build. - verifyFrom's cascade carries each row's depth from the basis that arrived, its own chain included. It does not check, or descend past, a row deeper than the bound: no read can produce those bytes, so the pass owes them no check. A delta that does not hash to its name past the bound no longer aborts the pass. - pathRows loses its step counter. Its visited marks already stop it at a row on a path, so it visits each row once, and the cascade's depth check bounds what it verifies. - seedcheck's chainRoot gives a chain that loops or runs past the bound no root, consistent with ErrChainUnresolvable: the row stays pending, withheld, and is never judged.

    Tests: - Closing a two-delta cycle is refused in under 5s (it took 27s). - A push onto a chain one past the bound is stored. - chainEnd stops exactly at its limit. - A dangling delta with a wrong name one node past the bound does not abort the push, whether the basis that arrives is full text or a delta deep on a held chain, while one within the bound is still checked and readable. - MarkPending gives an over-deep chain no root, so filling its far end examines nothing, and returns at once on a cycle. - TestHorizonOverDeepPendingChainDoesNotBlockFill still passes. - Removing each bound, the cycle check, the untracked store or the root depth fails a test. - chainDepth's own early stop is an equivalent mutant: the cascade's root has just been expanded, so its chain is within the bound unless the store is damaged. (user: [email protected], size: 18939) [annotate] [blame] [check-ins using]

  • 2026-10-24 13:16:06 — part of check-in [8d3b1ef28a] on branch main — Merge pull request #477 from danmestas/fix/bound-chain-walks

    fix(sync): bound basis-chain walks at the read depth (user: [email protected], size: 18939) [annotate] [blame] [check-ins using]

  • 2026-10-24 13:16:27 — part of check-in [707b42538c] on branch main — Merge branch 'main' into feat/horizon-seed-binding (user: [email protected], size: 18939) [annotate] [blame] [check-ins using]