Artifact Description [594dcaceab]

Artifact 594dcaceab1d58716c02a4c421289a7292caaa67e9fcbf5dc80eb9fa40d05036:

• File internal/sync/horizon_seedrefuse_test.go
  • 2026-10-24 06:59:39 — part of check-in [584c55d1fd] on branch main — fix(sync): judge pending rows when a received delta fills their basis (#471)

    Two review nits.

    Liveness. A pushed artifact pending on a basis P stayed withheld for good when a pull supplied P as a delta: - Only MarkPending re-rooted, and only for a pushed delta. - Filling a phantom with a delta runs no cascade, so nothing judged the waiting rows if the delta was readable, or moved them to P's own root if it was not. A later fill of that root never reached them.

    The fix is one hook at the choke point every received delta passes, storeDeltaContent: seedcheck.DeltaStored. - If the stored delta is readable, the rows pending on it are judged. - If not, they move to its chain root, so whatever finally resolves the chain judges them. - It replaces MarkPending's push-only re-root.

    Error surfacing. JudgeFilled still skips a row whose own bytes cannot be read (a delta that does not apply or fails its checksum, or bytes that are not the artifact named) and judges the rest of the batch. Any other failure is now returned, a broken chain to the filled root included: check-in and tag return it, and the cascade logs it, as it already did for JudgeFilled errors. The separate availability skip went with it.

    Tests: - A pushed plain file and control artifact pending on a basis that a pull supplies as a delta, on a held basis or on one that arrives in the next round. Both become readable and stop being withheld, are announced on a push-on, and the control artifact is linked. - A row whose content does not decompress is reported. - A checksum-failing row is skipped like an invalid one. - Each hook branch and each error class fails a test when changed. (user: [email protected], size: 37033) [annotate] [blame] [check-ins using]

  • 2026-10-24 07:10:38 — part of check-in [0b3bc67376] on branch main — Merge branch 'feat/471-seed-refusal' into feat/horizon-names-seed-refusal (user: [email protected], size: 37033) [annotate] [blame] [check-ins using]