Artifact 4ceed7c5fc64508f91ecf84b6b3861b3a1644f859917db463f9975324b93c55a:
- File
internal/verify/rebuild.go
-
2026-10-24 05:58:37
— part of check-in
[df78b8aee9]
on branch main
— fix(sync): never announce a withheld artifact from the client side (#471)
Review of 0e28b6a: when the origin pushed on to a peer, its own client announced artifacts its replies withhold. A pending seed went out from unclustered, and after verify.Rebuild (which marks every blob unclustered and unsent again) a refused seed went out too. The peer kept asking, loadFileCard withheld it, and the push ran out of rounds.
Fixed in the tables the client announces from, not in each reader: - MarkPending takes a pending row out of unclustered. - decide puts it back once judged not a seed; a seed stays out. - rebuildBookkeeping leaves withheld rids out of unclustered and unsent. - That also keeps them out of cluster minting, which reads unclustered. - sendPrivate and the private gimme answer, which read the private table, skip withheld rids. - sendUnclustered needs no filter of its own, and sendAllClusters lists only linked clusters, which a withheld row never is.
JudgeFilled now skips a row that does not expand (it stays pending) and judges the rest of the batch, instead of returning.
Tests: - A pending seed is not announced on a push-on, publicly or privately. - A peer asking for a private pending seed outside a private sync is not told it exists. - After a rebuild, a push-on converges and never names the refused seed. - A pending file, once judged, is announced again on a push-on. - An unreadable row does not stop the next fill in the batch being judged. - Every new mechanism fails a test when disabled. (user: [email protected], size: 5967) [annotate] [blame] [check-ins using]
-
2026-10-24 06:28:35
— part of check-in
[9f0b995575]
on branch feat/horizon-dfloor-receive
— Merge feat/471-seed-refusal into feat/seed-receive-drop
Takes the client-side announcement fix. A seed refused at the link step without a pending row (one a pull or clone completes in a later round) leaves unclustered through refuse(). A push-on from that store never names it, and a test now pins this. (user: [email protected], size: 5967) [annotate] [blame] [check-ins using]
-
2026-10-24 06:39:04
— part of check-in
[81d00b2e3b]
on branch main
— Merge branch 'feat/471-seed-refusal' into feat/horizon-names-seed-refusal
# Conflicts: # conformance/horizon_test.go # docs/site/data/conformance.json (user: [email protected], size: 5967) [annotate] [blame] [check-ins using]
-
2026-10-24 12:32:24
— part of check-in
[5a7c2ba12e]
on branch main
— Merge pull request #476 from danmestas/feat/horizon-names-seed-refusal
feat(horizon): named horizons with depth, and origin seed refusal (user: [email protected], size: 5967) [annotate] [blame] [check-ins using]
-
2026-10-24 05:58:37
— part of check-in
[df78b8aee9]
on branch main
— fix(sync): never announce a withheld artifact from the client side (#471)