Artifact e7222da51689c2ecc9ef6b6c3201911d73f8e59fa00846d6ac78332db8719e52:
- File
CHANGELOG.md
— part of check-in
[ddc4b5396d]
at
2026-10-12 18:01:26
on branch main
— fix(xfer): follow the draft's card grammar, not whole-message failure (#299) (#340)
The card decoder refused a card by failing the entire message: the server answered HTTP 400 where §5.2 has it emit "bad command" and parse on, and the client dropped a whole reply including its valid prefix.
The decoder now yields a bad-command card for a line no rule accepts (an unknown operator, a bare pragma, a gimme with a surplus token, a config with a signed size) and a bad-file card for a file/cfile/uvfile line it cannot frame. The server resets its reply, emits the matching error (bad command, or the handler's "malformed file line" and the like) and either parses on (bad command) or stops (bad file), as fossil's page_xfer does; the client ends the reply-card loop, keeping the cards decoded before the bad one; a clone treats it as a non-retryable protocol error.
Tokens are split on ASCII whitespace only, within fossil's six-token window (blob_tokenize over aToken[6]): a no-break space no longer separates tokens, and a seventh token is ignored rather than rejected, so igot and private tolerate a surplus token. A full cfile's USIZE is carried through as metadata, not checked against the inflated size (the hash binds the content instead), and the byte after a config payload is consumed whatever it is, both matching fossil's xfer_accept_compressed_file and page_xfer.
This also resolves the bad-command cases tracked in #300 (sync.5.2.bad-command, .bad-command-resets, .unknown-prefix, sync.10.1.bad-command-keeps-mutations), whose marks are removed here. (user: [email protected], size: 56317) [annotate] [blame] [check-ins using]
# Changelog All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] ### Fixed - `verify.Rebuild` now derives repository state through the crosslink sweep rather than its own partial derivation (#285). It kept a second derivation that wrote rows only for check-ins and control artifacts: no cluster, wiki, ticket, technote or forum events, applied tags from artifacts the crosslink would refuse, skipped absent tag targets and parents instead of reserving phantoms, wrote no plink `baseid`, and computed leaves by "no child at all" regardless of branch. Rebuild now empties the derived tables and runs the same sweep a clone runs, so derived state has one owner and matches `fossil rebuild` in event, plink, mlink, tagxref, leaf and phantom. A new `manifest.CrosslinkRebuild` runs that sweep in a terminal mode that links a check-in whose content is absent with phantoms rather than deferring it for a blob that will never arrive, as `fossil rebuild` does. Its branch-aware leaf rule now follows fossil, so an untagged parentless check-in is no longer a leaf (the §7.3 erratum the sweep already observed). - The xfer card decoder now follows the draft's card grammar instead of failing a whole message on one bad card (#299). A line no card rule accepts (an unknown operator, a bare `pragma`, a `gimme` with a surplus token, a `config` with a signed size) decodes to a bad-command card: the server resets its reply, answers `error bad command: <LINE>` and parses on, and the client ends the reply-card loop keeping the cards before it. A `file`, `cfile` or `uvfile` line that cannot be framed decodes to a bad-file card: the receiver emits the handler's message (`malformed file line` and the like) and stops, as fossil's `page_xfer` breaks. Tokens are now split on ASCII whitespace only, within fossil's six-token window, so a no-break space no longer separates tokens and a seventh token is ignored rather than rejected; `igot` and `private` tolerate a surplus token. A full `cfile`'s USIZE is treated as metadata, not checked against the inflated size, and the byte after a `config` payload is consumed whatever it is, both matching fossil. - `Repo.ResolveVersion` now follows fossil's `symbolic_name_to_rid` name resolution (src/name.c): it chooses a tag by the carrying check-in's `event.mtime` rather than `tagxref.mtime`, no longer falls back to the tip when no check-in carries `sym-trunk`, tries an artifact-hash prefix before a plain tag, and accepts the `rid:`, `tag:`, `root:`, `start:`, `merge-in:` and `NAME:TIMESTAMP` forms plus a trailing-punctuation retry. A hex prefix now must be 4–64 characters, as fossil requires (#290). - `branch.Create` now refuses a name an open branch already carries, as `fossil branch new` does, and stores no artifact when it refuses. `branch.List` now reports a branch closed only when its newest check-in carries a `closed` tag (fossil's branch-list rule), not when any check-in on the branch does (#292). - `checkout.BranchLeaves` now returns only the *open* leaves of a branch, skipping any leaf that carries a `closed` tag, as fossil's `leaves` lists them. `(*Checkout).WouldFork` is now fossil's `leaf_ambiguity`: it reports a fork only when the current version is itself an open leaf and another open leaf exists on the same branch, so a non-leaf or closed version no longer reads as a fork (#291). - A repository with no `hash-policy` row names new content as fossil's `hname_default_policy` does (#274): SHA3 when it is empty or holds a SHA3 artifact, SHA1 (policy `auto`) otherwise. It used to name an empty repository's first artifact with SHA1. And when an `auto` repository takes in its first SHA3-named artifact, the promotion is written to the `hash-policy` setting, as fossil's `content_put` does, so fossil opening the repository agrees. It used to be derived from the stored names only. - `ListFiles` and crosslink reject a B card whose target is not a baseline manifest (#275): a delta manifest or a control artifact used to be accepted as the baseline, giving a partial or empty file set instead of an error. - `Checkin` refuses a filename the artifact format's writer profile forbids (#270): one containing a backslash, or that is not valid UTF-8 (surrogates and overlong forms included). It used to write a manifest naming it. fossil's own `add` refuses such names, so fossil never creates that manifest, but its reader still accepts one that arrives from elsewhere. The draft's writer profile also bars characters above U+FFFF, private-use characters and noncharacters; those are not enforced here. - `delta.Create` refuses a source or target of 2^32 bytes or more with `delta.ErrTooLarge` (#279), as the delta format's producer bound requires; it used to write header and copy integers of 2^32 or more. `Create` now returns an error, and `Deltify` stores such content whole, as fossil does when a delta is not worthwhile. `Apply` now rejects a header naming exactly 2^32 as well (the draft leaves that limit implementation-defined), so what `Create` writes and `Apply` reads agree. - Storing content whose name is a phantom fills the phantom in place, as fossil's `content_put` does (#278). `blob.Store` used to return the phantom's rid and leave it empty, so a check-in of a file matching a known phantom recorded a manifest pointing at content that was never stored. - `Repo.Tag` now places a tag name in the symbolic namespace with a `sym-` prefix and refuses the reserved `wiki-`, `tkt-` and `event-` prefixes, as `fossil tag add` does for a check-in. It used to store the name verbatim, so the tag did not resolve as a branch/tag name. Callers pass the bare name. - Cancelling a propagated tag no longer deletes an inherited row that is newer than the cancellation. The cancel walk carried no mtime guard (`COALESCE(srcid=0, 0)`); it now matches fossil's `tag_propagate` (`srcid=0 AND tagxref.mtime < ?`), removing an inherited row only when it is older and halting the descent at a newer one (#288). - The singleton `parent` (reparent) tag is now applied: the tagged check-in's plink and mlink rows are rewritten to the parents the tag names, and the affected leaves are recomputed, as fossil's `manifest_crosslink_end` does. An old parent left without a child becomes a leaf, matching `fossil rebuild`. Both the crosslink sweep and `verify.Rebuild` apply it (#286). - A technote whose T-card names another artifact, or propagates or cancels, is now refused at crosslink time and applies none of its tags, as fossil refuses it at parse time. A technote may only carry `+` (singleton) tags on itself (#287). - Crosslinking a root check-in a second time no longer duplicates its mlink rows. The root-file path inserted each row with no "already derived" guard, so a re-crosslink (as the relink path does after clearing event/tagxref) doubled them; it now skips the block when the rows are already present, as `manifest_crosslink` is idempotent (#294). - The first check-in's `sym-trunk` tag is now propagating (`*sym-trunk`), matching `fossil new` and repo-state §6.1, so the trunk alias descends to every check-in on the branch. It used to be written as a singleton (`+sym-trunk`), which stopped at the root (#289). - `deck.Parse` applies the §5 structural-type rules once a type is determined: the §5.2 card-legality table (each type's allowed and required cards, from fossil's `manifestCardTypes`), so a card the type disallows or a required card left out is rejected, and the §5.4 semantic checks -- a control artifact's tags may not target itself, a technote's tags are all self-referential singletons, a forum post carries at most one of an H or I card and at most one parent. Type determination now falls back to a control artifact (not an empty check-in) when no card sets a type and there is no comment, file or parent, matching fossil. This also makes a missing Z card a required-card rejection rather than a special case (#273). - `deck.Marshal` re-encodes what `deck.Parse` read, so `Marshal(Parse(x)) == x` for a canonical artifact. A present-but-empty C comment, N mimetype or T value, and a bare P card, are kept distinct from an absent one and re-emitted (an empty W body already was, now via nil versus a non-nil empty slice); the distinction is carried in unexported Deck/TagCard fields, so a caller that builds a deck and sets a non-empty value still has it marshalled and the public API is unchanged. The D and E timestamps are written at their writer precision -- millisecond for D, second for E -- extended to keep any finer fraction the parser read, so a sub-second timestamp round-trips instead of being truncated (#272). - `deck.Parse` parses D and E timestamps with the §4.6.4 grammar (as amended by the §4.6.4 erratum) instead of two fixed `time.Parse` layouts. It accepts the date-time form with `HH:MM`, `HH:MM:SS` or a fractional second, a `Z`, `z`, `+HH:MM` or `-HH:MM` timezone, one or more whitespace-or-`T` separators, the hour 24 and an unchecked day (`2024-02-31` rolls forward, as SQLite's `julianday()` does), and a date at or after `-4713-11-25`; it applies the exact-digit field ranges (year 4 digits, month 01-12, day 01-31, hour 00-24, minute and second 00-59) and rejects a lowercase `t` separator rather than silently rewriting it to `T` (#271). - `deck.Parse` applies fossil's §4.6 name predicates. An F-card filename and old-name, and an A-card filename, must be simple pathnames (§4.6.1): no leading or doubled or trailing slash and no "." or ".." path element, the non-strict form fossil uses, which still admits a backslash or non-UTF-8 byte. An L-card title and an A-card target (when not a hash) must be well-formed wiki names (§4.6.2): 1 to 100 bytes, no leading, trailing or doubled space and no control byte. A reserved repository filename (`_FOSSIL_`, `.fslckout`, in either case, with an optional -wal/-shm/-journal suffix, at the root or as a path's last component) is silently dropped from an F-card list after the sort-order check, exactly as fossil does (#269). - `deck.Parse` validates every artifact-hash position against the §4.7.1 map: the A source, B, the E identifier, each F hash, G, I, M, every P token, both Q tokens, and the T target must be 40 or 64 case-insensitive hexadecimal characters; the K ticket id is pinned to 40; the R checksum to 32. A hash is required on every F card of a baseline manifest (only a delta manifest may carry a hashless deletion card). The A target and the N mimetype are now escape-decoded on parse and re-encoded on marshal, matching §4.3.1, while the other hash tokens stay raw; the A filename keeps only its final path component. The Q sign must be `+` or `-`, a tag name that is entirely hexadecimal (either case) is rejected, and these checks reject malformed tokens fossil also rejects, such as a hash carrying a stray carriage return (#268). - `deck.Parse` tokenizes artifact cards the way fossil does (its `next_token`/`next_card`): tokens are separated by a single space, a card ends at LF, and tab and CR are ordinary token bytes rather than whitespace to split or trim on. A blank line, an empty token between two others (two spaces in a row), a bare card where a value is required, and trailing residue after the last card are each rejected; a line that ends in a space still carries a present-but-empty last value. The W card's size is read as fossil reads it -- leading decimal digits, with an overflow guard -- and the body must be followed by a newline. The clearsign armor trailer is matched on 29 bytes, as fossil matches it, so a mangled final dash no longer hides the signature. Each card is also held to its exact §4.2.1 arity: a card with more tokens than Table 2 allows is rejected (#266, #267). - `deck.Parse` and `deck.VerifyZ` judge an artifact's framing by the rule it breaks. The Z-card check now mirrors fossil's `verify_z_card`: it locates the Z card as the last 35 bytes beginning `Z `, never reads the final byte, treats a body too short or without a trailing Z card as "Z card absent", and reports only a present-but-wrong checksum. `Parse` gained the §4.1 framing gates fossil applies up front -- a non-empty blob ending in LF, checked on the raw bytes before the signature wrapper is stripped, and a first card that is an upper-case letter followed by a space -- and a missing Z card is now rejected by the required-card rule rather than by the checksum. Artifacts rejected for a missing final LF, residue after the Z card, or a bad first line are no longer blamed on the checksum (#265). ## [0.11.1] - 2026-10-11 ### Security - The sync server sends repository content only to a requester allowed to read it (GHSA-mvx3-6793-8x4r). It used to answer `gimme HASH` with the artifact whether or not a pull was accepted, and `pragma uv-hash`, `uvgimme` and `uvigot` with the unversioned catalog and files, to any requester, anonymous ones included. As in fossil's `page_xfer`, `gimme` is now answered only in a session whose `pull` card was accepted, or in a clone, and the unversioned catalog and files go only to a requester with Read (o, i, or Admin). `uv-push-ok` is sent only to a requester who may write unversioned files (y); a reader without it gets `uv-pull-only`, as fossil sends. The same rules apply to table sync: `xgimme` needs an accepted pull and `pragma xtable-hash` needs Read. A `uvigot` no longer updates an unversioned file's mtime for a requester without y, and `pragma ci-lock` takes or reports a check-in lock only for a requester with Write (i), so an anonymous requester can no longer learn who holds a lock. This is a deliberate departure from fossil, which takes a lock for any requester; fossil's own client asks for one only before a commit, which needs Write. - The HTTP sync transports follow redirects as fossil does rather than as Go's `net/http` does (GHSA-3f8x-8fr5-mr98). They used to follow a redirect from HTTPS to plain HTTP, which resent the request, login card included, in cleartext. They now refuse it, and follow a 301, 302, 307 or 308 by re-POSTing the same body and Content-Type, with one trailing `/xfer` stripped from the new location, failing on the twentieth redirect. A 301 or 302 used to become a GET without the body, and a chain stopped after 10. This applies to `NewHTTPTransport`, whatever `http.Client` it is given. ## [0.11.0] - 2026-10-10 ### Added - `Checkout.Merge` merges another checkin into the checkout, as fossil's `merge` does, and `Checkout.Conflicts` lists the files left in conflict (#244). The merge is recorded the way fossil records one, so fossil reads it and commits it, and the next `Checkin` records the merged-in checkin as a merge parent. A file edited here but deleted in the merged-in version is kept rather than deleted, and a merge that would overwrite an untracked file is refused: go-libfossil has no undo copy to recover them from. A change the merged-in version made to a file's executable bit is taken. Renames are not followed yet. - `CheckoutCommitOpts.Files` commits only the named files, and `CheckoutCommitOpts.AllowConflict` commits files that still hold conflict markers (#244). ### Changed - Merge conflicts use fossil's conflict markers, with the common ancestor shown between the two sides, so fossil sees a conflict go-libfossil wrote, and the other way round (#244). This applies to `Update` as well as `Merge`. A file is in conflict while it holds markers; there is no separate conflict state to clear. - The CLI's `merge` command calls `Checkout.Merge` (#244). It merges into the checked-out version; it used to merge against the repository's newest checkin, which made merging a branch that is the newest checkin a no-op. It no longer writes `.LOCAL`, `.BASELINE` and `.MERGE` files beside a conflicted file, since the markers now include the common ancestor. `mark-resolved` refuses a file that still holds markers, and `conflicts` lists the files that hold them. - **Breaking (CLI):** `repo ci` commits the checkout, as `fossil commit` does (#244). It used to commit the named files straight to the repository on top of its newest checkin, ignoring the checkout, so it could not record a merge and left the checkout behind. Run it in a checkout (or pass `-d`); with no files named it commits every change. The `--parent` flag is gone, since a checkout always commits onto its own version. `--allow-conflict` commits files that still hold conflict markers, and `--allow-empty` commits when nothing has changed. - `Checkout.Checkin` refuses files that still hold merge conflict markers, as fossil's commit does, unless `AllowConflict` is set (#244). - **Breaking:** `Checkout.Checkin` refuses a commit with nothing changed and no merge pending ("nothing has changed"), as fossil's commit does, unless `CheckoutCommitOpts.AllowEmpty` is set (#244). It used to record a checkin identical to its parent. A named file the checkout does not track is refused too; a named directory selects the tracked files under it. - `stash.Save` refuses while a merge is pending (#244). A cleanly merged file looks like a plain edit; stashing it left the merge record naming content that was no longer in the checkout. ### Fixed - A pull-only `Sync` converges when the client holds artifacts the server lacks (#277). The server used to answer the client's `igot` cards with `gimme` for them even though the client was not pushing, so the client never satisfied the request and the pull ran to `exceeded 100 rounds`. The server now asks only a pushing client, as fossil does, and a client that is not pushing ignores any `gimme` it receives. - `Repo.Annotate` credits each line to the right check-in when edits shift line positions between versions (#253). Past the first parent it used to write each line's attribution by its position in an older version, so lines were credited to the wrong check-in, and an older version with more lines than the starting one panicked with an index out of range. - Check-in, parent-link and tag rows store the values fossil stores (#258), whether written by a commit, a crosslink or `verify.Rebuild`. Times match bit for bit: tag times are SQLite's `julianday()`, and event, plink, attachment and forumpost times are that value as fossil writes it into SQL text, which keeps 16 digits; they used to differ in the last digits. Fossil's own text conversion depends on the platform it was built for, and this follows the macOS and Windows builds. A check-in's `omtime` is recorded (it was NULL), and a tag without a value is stored as NULL rather than an empty string. The CLI's `repo tag ls` reads such tags, which it used to misprint. - Clone and sync exchanges follow draft-fossil-sync-protocol-00 (#255). A clone reply sends an artifact stored as a delta as a `cfile` naming its source, as fossil does in a version-3 clone; it used to send a `file` card. A clone session stops asking once the server sends `clone_seqno 0`, sending at most one cleanup request with no operation; it used to switch to `pull` to fetch missing artifacts, which the draft forbids. `Clone` now fetches any artifact still missing with a separate pull session afterwards, and still fails if one cannot be had: unlike the draft, which ends a clone with phantoms left, `Clone` returns only a complete repository. A clone the server stops before `clone_seqno 0` fails rather than returning part of a repository. A sync now asks once, in its first round, for the phantoms a repository already holds, as fossil's does, without letting one the server lacks hold it open. Every request ends with a random comment, not only those with a login, and every completed reply ends with fossil's timestamp comment. - `Repo.Annotate` credits lines the way `fossil annotate` does (#256, #257). It now uses a port of fossil's own line diff and, like fossil, diffs each older version against the starting one. Where a line repeats (blank lines, braces), which copy counts as new depends on the diff's tie-breaking, and go-libfossil's diff used to pick differently, crediting such lines to other check-ins. Trailing blank lines are no longer dropped from the result. On the RFC, althttpd, pikchr and wapp repositories every annotated file now matches `fossil annotate` line for line. A line's text no longer includes a trailing carriage return, a leading byte-order mark is ignored, and a file fossil will not diff (one with a NUL byte, or a line over 32,767 bytes) returns an error. Annotate no longer allocates a table the size of both versions at every step. - `Checkout.Checkin` records pending merges as merge parents, including merges made by the fossil binary (#244). It used to drop them, so a merge committed through go-libfossil looked like an ordinary commit. Committing only some files of a merge is refused, as fossil refuses it. - `Checkout.Checkin` of a checkout with no version and nothing added returns an error instead of panicking (#244). - The CLI's `merge` recorded a conflict as `chnged=5`, which fossil reads as "added by integrate", and recorded no merge parent (#244). ### Security - A sync card whose size is not a plain decimal is a decoding error. A negative size, as in `file HASH -1`, used to panic the client or server reading the message, and a signed size such as `+5` was read as a size. Sizes follow draft-fossil-sync-protocol-00's `decimal` grammar and fossil's 32-bit limit, and a `uvfile`'s FLAGS take the same rule, so negative FLAGS are rejected as the draft requires. A declared size no longer sets how much memory is allocated before the payload arrives: the buffer grows with the bytes read, so a large size over a short message fails without allocating it. A `cfile` payload may inflate only to its USIZE, or to a margin above USIZE for a delta, and not past its 4-byte size prefix, and all `cfile` payloads in one message may inflate to at most `MaxCFileInflateBytes` (1 GiB) together; a few megabytes of zlib could otherwise inflate to tens of gigabytes. A single artifact larger than that cannot be received as a `cfile` (GHSA-j99p-mw22-69c8). - An `xrow` payload or `xdelete` PKData must be one JSON object whose values are scalars and whose primary-key values have the column's type; anything else is refused with an error, on the client and the server. JSON `null` used to panic the process, as did a primary-key value of the wrong type or a nested value. A client refuses an `xrow` for a table it has not registered (GHSA-j99p-mw22-69c8). - A synced table's row can no longer rewrite the SQL that stores it. Keys of an `xrow` payload or `xdelete` PKData were written into `UpsertXRow`'s `INSERT` as column names unchecked, so a peer could choose the statement's columns and values, or select from other tables into a synced one. A peer's row must now use exactly the table's declared columns, and `UpsertXRow` refuses any key the table's registered schema does not declare. Every other function that writes a synced table or column name into SQL validates it first (GHSA-9fq6-h6xw-274g). - The HTTP transports read at most `xfer.MaxBodyBytes` (65 MiB) of a reply and return `xfer.ErrBodyTooLarge` past it; a server streaming an endless reply used to be read into memory whole (GHSA-j99p-mw22-69c8). - The sync server answered `reqconfig NAME` with any row of the `config` table, to any requester, including one with no capabilities, so it disclosed `project-code`, `server-code` and every local setting. It now answers as fossil does: only a `/GROUP` request, only for a requester with Read, and only with the names fossil transfers in that group. The user and subscriber tables also need Admin, which counts only for a verified login, and concealed addresses need RdAddr (`e`). A refused request gets no cards and no error, so the rest of the exchange goes on. Groups are sent in fossil's encoding, so `fossil clone` and `fossil config pull` against this server now receive the skin, project, ticket, shun and alias settings (GHSA-p6w4-4xqc-jhq2). - The sync server checks a login card's nonce against the request body, as fossil does (GHSA-2g5p-q5f3-477p). The nonce must be the SHA-1 of the decompressed bytes after the login line; it was never checked, so a login card captured from one request authenticated any other request body. A refused login now ends the exchange with fossil's `error login failed` instead of carrying on as nobody, and a second login card is refused. A successful login adds the user's capabilities to nobody's instead of replacing them. As in fossil, `nobody` and `anonymous` log in without a password, and accounts with no stored password, `developer` and `reader` cannot be logged into. - **Breaking:** A new repository gives its built-in users the capabilities `fossil new` gives them. `nobody`, whose capabilities every request without credentials gets, may now clone, read and download (`gjorz`); it used to be granted `cghijknorswy`, which let anyone push check-ins and unversioned files, write wiki pages and tickets, and act with Setup. The repository also gets fossil's `anonymous`, `developer` and `reader` users. The creating user, who holds Setup, can now push and pull once given a password, as Setup includes those rights in fossil. A login is refused for any account with no password stored, as fossil refuses it (GHSA-44p2-whvx-9gwq). Migration: new repositories no longer let anonymous users push. To allow it, grant it explicitly, for example `r.SetCaps("nobody", "gijoryz")`, or give clients an account with a password. Existing repositories keep the capabilities already stored in them. ## [0.10.0] - 2026-10-03 ### Changed - `Checkout.Revert` keeps a never-committed file on disk when it reverts the add (#234). It used to delete the file, destroying the only copy. It now un-manages it and leaves it in place, as fossil's `revert` does. `Revert` also checks the disk first, so an edit that no scan has recorded yet is reverted instead of silently skipped; restores a file that is missing from disk; and, when reverting everything, drops a pending merge completely (merged-in versions and the merge record), as fossil does. - `Checkout.Rename` refuses to move a file onto one that already exists on disk, as `fossil mv --hard` does, before changing anything. It used to overwrite it. ### Fixed - `Checkout.Revert` undoes a pending rename, as fossil's `revert` does (#242). It used to leave a rename made with `fossil mv` in place, and restored a renamed, edited file's content under its new name. The file now goes back to its old name with its committed content, and either name can be given. When undoing a rename would land on a name another file now holds (a swap, a new file added under the old name, or an untracked file there), `Revert` refuses and changes nothing rather than overwrite it: go-libfossil has no undo copy to recover it from (#248). Naming several files reverts them as one: if one is refused, none is reverted. - A dry-run `Extract` or `Update` no longer changes the checkout (#236). Both used to replace the checkout's file list and move its version to the target, losing pending adds, renames and merge state, even though no file was written. Switching versions with `Extract` now also ends any pending merge, as fossil's `checkout` does, so a forced switch can't leave a merge record behind to give the next commit a bogus merge parent; re-extracting the current version without `Force` keeps it. A forced `Extract` starts the checkout's file list fresh, as `fossil checkout --force` does, so a pending rename or removal no longer survives it. - A database fault while checking whether content is present no longer reads as "content missing" where missing content is tolerated (#239). Since #231, `CreateCheckout` on a partly synced tip leaves the checkout's file list empty instead of failing; a busy or failed database during that check was treated the same way, so `Create` quietly succeeded with an empty checkout. The fault is now reported. New `content.CheckAvailableByUUID` returns the error; the existing boolean checks still treat one as unavailable. - The CLI's `add`, `rm`, `rename` and `revert` commands call the library instead of writing the checkout database with raw SQL (#234). `rename` now moves the file, like `fossil mv --hard`, instead of leaving it under its old name where the next commit couldn't find it. `revert` restores committed content instead of only clearing change flags. Errors, including from closing the checkout, are reported instead of ignored. Without `-R` they find the repository the checkout records, including a relative path as `fossil open` stores it. - The internal stash no longer drops files changed by a merge (#233). It selected only `chnged=1`, leaving out fossil's merge states, and stashed a rename as a plain edit. It now selects changes the same way `Status` does, and refuses a pending merge, a permission change or a rename by name, since it can't yet stash those faithfully. The stash isn't reachable through the public API yet. Checkin and stash now read the checkout through one internal package, `internal/vfile`, which is the only place fossil's checkout encoding is interpreted. - `Status` reports tracked files that are gone from disk as `missing`, as fossil's `changes` command reports MISSING (#232). They used to be left out, or shown as `added` or `modified`. `HasChanges` now sees a pending add made by the fossil binary without a scan first. Both now share one classifier, so they can no longer disagree about what counts as a change, and Status lists files by name. A directory where a tracked file belongs is reported as `missing` rather than failing the scan. A checkout written by an older go-libfossil may still hold `rid=0` rows for content that was missing from the repository (see #231); `HasChanges` now counts those, and `Extract` of a complete version replaces them. - Checking out a version whose content is partly missing, as a partial sync leaves it, is now refused up front with an error naming the files (#231). go-libfossil used to record such files with `rid=0`, which in fossil's checkout format means "added", and `Extract` then panicked trying to read them. This matches fossil, which refuses with "missing content". A `CreateCheckout` whose tip is still partly synced no longer loads the tip's files, so extracting an older, complete version still works. - A non-forced `Extract` now checks before it changes anything (#230). It used to replace the checkout's file list first, so a refusal lost pending adds, renames and merge state and left `Status` seeing an empty checkout. It also compared disk with the target version, so a clean checkout could not switch to a version that changed a file. Extract now follows fossil's `checkout`: it refuses while the current version has unsaved changes that the switch would lose, or when an untracked file sits where the target would write different content. A tracked file that is missing from disk no longer blocks a switch, as in fossil. - Reading a stored artifact could return compressed bytes (#235). `blob.Load` treated a row as stored uncompressed whenever its stored length equalled `blob.size`. For a delta row those are different things (the compressed delta and the full artifact's length) and can be equal by chance, so the delta step then failed. Fossil always inflates `blob.content`, and so does go-libfossil now. Go 1.27's new compressor made one test fixture hit the case, but any repository could. - Checkouts created by the fossil binary (`fossil open`) now work through `OpenCheckout` (#228). `Status` failed outright with `converting NULL to string` on `vfile.mhash`, because go-libfossil judged every file against that column, which fossil only fills while a merge is pending. Change detection now follows fossil's own scan: a file is compared with the artifact `vfile.mrid` names, adds and merge states move through the same `chnged` transitions, and fossil adds, renames and `origname==pathname` rows are classified the way fossil classifies them. - A non-forced `Extract` no longer overwrites uncommitted work in a fossil-made checkout. The local-edit guard swallowed the same NULL scan error and skipped its check, and it never considered a merge that fossil had applied but not yet committed; both now refuse unless `Force` is set. - `Add` writes `vfile.islink`, which fossil's checkout schema declares with no default, so a file added by go-libfossil to a fossil-made checkout reads back cleanly in both tools. New rows no longer populate `mhash`. ## [0.9.0] - 2026-08-07 ### Fixed - New artifacts are named with the algorithm the repository's `hash-policy` selects, rather than always SHA1. Committing into a repository whose policy is sha3 -- the `fossil init` default since 2.10 -- wrote SHA1 artifact IDs, so every F-card in the new manifest carried a differently-derived hash from the one already in the parent manifest and `fossil diff` reported every tracked file as CHANGED even when one file had been edited. Repository integrity was never affected and canonical fossil could always read the result; the damage was unreadable diffs and a permanently mixed-hash repository, plus artifacts a `shun-sha1` peer would reject. Content already stored under the other algorithm's name is reused rather than stored a second time, unless the policy forbids it (`sha3-only`, `shun-sha1`). Without that, a repository holding SHA1 artifacts under a sha3 policy would churn every F-card on its next commit -- the same every-file-CHANGED symptom, mirrored. Only a stored blob qualifies: a phantom is a name the repository knows of but has no content for. `checkout.Manage` and `uv.Write` read the same policy instead of each guessing from the width of an existing name. `uv.Write`'s guess read `project-code`, which is 40 hex characters in every repository whatever the policy, so it could only ever choose SHA1. - Repositories created by this library are seeded with `hash-policy`, so they name artifacts the way `fossil init` does. Without the row, naming derived the algorithm from the repository's own artifacts, and a repository with no artifacts yet settled on SHA1 -- then stayed there permanently, because the first artifact it wrote was SHA1 too. A clone is the exception and keeps no seeded policy: it adopts its source's, which the absent row expresses by deriving the algorithm from the artifacts the clone actually receives. Canonical fossil propagates the source's policy value into a clone; the sync protocol carries no configuration, so this reaches the same answer by inference. The two differ only for a source explicitly set to `sha1` that nonetheless holds a SHA3 artifact. ### Added - `db.HashPolicySHA1`, `db.HashPolicyAuto`, `db.HashPolicySHA3`, `db.HashPolicySHA3Only` and `db.HashPolicyShunSHA1` name Fossil's `hash-policy` values, so the seed path and the naming path read one definition instead of each carrying its own copy of the enum. ### Changed - Repositories created by this library now name their artifacts SHA3 rather than SHA1. No API changed, but the same content committed into a newly created repository produces a different artifact ID than it did in 0.8.1. Existing repositories are unaffected: their artifacts keep their names, and their own `hash-policy` continues to decide how new ones are named. ## [0.8.1] - 2026-07-30 ### Fixed - Crosslink reports the underlying cause when it fails, instead of replacing it with a generic message. - Test fossil servers are reaped before their temporary directories are removed, and the unit-test timeout was raised; leftover servers holding files open made teardown flaky. ### Changed - Generated and local-only files are no longer tracked. ## [0.8.0] - 2026-07-29 ### Fixed - `mlink`, `plink`, `tagxref` and `leaf` are derived the way canonical fossil derives them, in both the sweep and the commit path, including deriving `leaf` by canonical's branch rule. mlink derivation, previously duplicated, is now unified in one place. - Tag propagation stops at branch boundaries instead of crossing them, and the three tag-apply paths share one propagation helper. - Authenticated sync interoperates with canonical fossil. - Clone retries a dropped exchange round instead of aborting. - The project code is derived, and artifact visibility is written inside the storing transaction rather than after it. - Ticket artifacts are crosslinked, and ordinary file blobs no longer emit a warning. - Checkins cascade-linked while referencing unavailable blobs are deferred until those blobs arrive. - Submodules are pinned to v0.7.0 rather than an orphaned pseudo-version. ### Added - The CLI selects its SQLite driver by build tag. ### Performance - Clone no longer re-seeks `blob.uuid` per F-card, and no longer over-allocates delta output. - The post-sync crosslink sweep no longer re-examines the whole repository. - Content received during sync is reused in crosslink instead of being read back. ## [0.7.0] - 2026-07-27 ### Added - `libfossil version` prints a single, stable, machine-parseable build identifier -- module version (or a `-ldflags -X github.com/danmestas/go-libfossil/cli.buildVersion=...` override for release builds), Go toolchain version, and platform -- and exits 0. Previously `version` was not a recognized command at all and fell through to the unrecognized-argument path. There is no global `--version` flag: `repo extract` already owns `--version` as a command-scoped flag (the source version to extract), and kong's global flags are visible in every subcommand's context, so a root-level `--version` would collide with it. - `libfossil repo serve` CLI command wires the already-public `Repo.ServeHTTP` xfer HTTP server into the command surface. A repository created or cloned with this tool can now be served to a peer -- including a stock `fossil clone` -- without writing Go. Binds to `127.0.0.1:8080` by default; override with `--addr host:port`. Process interrupt (Ctrl-C/SIGTERM) cancels the same context `ServeHTTP` already shuts down on; no new shutdown mechanism was introduced. ### Fixed - The xfer HTTP server now sends an explicit `Content-Length` on every clone and sync reply. The full response is already materialised by `Encode` before the first byte is written, so its exact length is known for free; setting the header keeps `net/http` from silently switching to `Transfer-Encoding: chunked` once the buffered body passes its internal flush threshold. Release-tagged fossil ≤2.23 reads the reply length only from `Content-Length` (`src/http.c` leaves its `iLength` negative otherwise) and aborts with "server did not reply" on any chunked reply above ~256KB, so those clients could not clone a repository larger than that from a libfossil server. No buffering was introduced — the response was always fully in memory — so #88's per-clone bound (`DefaultCloneBatchBytes`) still caps each reply. The fix is unconditional rather than negotiated: because the server never streams, chunked framing offers no memory saving over `Content-Length`, and `Content-Length` is what canonical fossil's own server emits, so it is strictly the more compatible framing for every client (issue #101). - The message decoder now selects a body's framing from its §4 Content-Type rather than by trying each framing and seeing which parses. A body sent as `application/x-fossil` is decoded as the §4.1 compressed container; every other type, including `application/x-fossil-uncompressed` (used by clone-v3 replies), is decoded as plain card text — the same rule canonical fossil applies. Trial-based dispatch made a decompression failure indistinguishable from "wrong framing"; a compressed body that now fails to inflate is reported as the fault it is and never re-fed to the card parser. The former unprefixed raw-zlib framing was removed: it was checked before the prefixed container on the belief that real fossil emits it, but a fossil 2.28 server never does — its pull replies are the prefixed container and its clone replies are plain text — so the framing was only ever right by accident. Removing it also retires the length-prefix/zlib-header aliasing guard, which existed solely to disambiguate the two compressed framings that trial-dispatch conflated. `xfer.Decode` now takes the Content-Type; call sites that carry no header (the byte-oriented NATS transport, both ends libfossil) pass the compressed type explicitly, matching what they always emit. The HTTP server rejects a request body whose Content-Type is absent or neither §4 type with 415 Unsupported Media Type instead of decoding it as plain card text: bodies come from untrusted peers, and without a framing signal decoding either way is a guess. Real fossil always sets the header, so no conforming peer is affected. (#106) - A large artifact now clones regardless of its position within a clone round. The server charged its batch budget before each artifact and sent the one that crossed it whole, so a round carried `budget + one whole artifact` — and when ordinary sub-budget filler preceded a large artifact, that sum exceeded what the client could decode (`xfer.MaxDecompressedBytes`), failing the clone with a spurious "declared container length exceeds" error. The size at which a clone failed depended on incidental filler: 8–15 MB of filler ahead of a 58.7 MB artifact all failed, while 17 MB passed by pushing the artifact into a round of its own. `emitCloneBatch` now flushes the round and sends an over-bound artifact alone when adding it would cross the client's decode bound, so the ceiling is a property of the artifact alone. The `2 * budget` compile-time guard now certifies what it appears to: filler plus one budget-sized artifact always fits in a decodable round. (#109) - A clone from a libfossil server could fail with a card-syntax error (`decode card 16303: empty line after split`) naming a card the response never contained. The message decoder tried three body framings in order and treated any decompression failure as "not this framing", so a well-formed compressed body that exceeded the decoder's own size bound fell through to the uncompressed branch and the still-compressed bytes were parsed as card text — thousands of nonsense cards until one split into no fields. Worse than the misleading error, an oversize or truncated compressed body was *accepted*: the garbage cards decoded without error and the artifacts they carried failed their hash check downstream. A body recognizable as zlib is now decompressed or reported, never reparsed. The bound is also raised to 64 MiB, since it sat below what this implementation's own server emits in a single clone round — two libfossil peers could not reliably clone from each other even though each could clone from fossil. A compile-time guard keeps the bound at least twice the server's clone *batch budget*, so filler plus one budget-sized artifact always fits in a round the client can decode. (#104) - Committing a file with zero-length content panicked in `blob.Store`, which treated an empty artifact -- a normal, well-known Fossil blob -- as invalid input; the panic then triggered `manifest.Checkin`'s postcondition defer, which re-panicked with an unrelated "manifestRid must be positive" message that masked the real cause. `blob.Store` now accepts zero-length (and nil) content, and `Checkin`'s defer re-panics with the original panic value instead of asserting a postcondition that was never going to hold mid-unwind (#68). - A commit no longer silently carries a tracked file's last-committed content forward when that file has been deleted from disk without `Unmanage`/`Remove` -- it now fails clearly, naming the file, matching fossil's own behavior for a missing file that is in scope for the commit being made. A missing file outside the commit's scope (relevant only to an explicit `Enqueue`) is left untouched exactly as before (#79). - Clone deadline now interrupts the mid-round phantom-fill crosslink cascade, ensuring the clone does not stall with phantoms outstanding. The same deadline is now threaded into the general push/pull phantom-fill cascade for consistency. - Sync replies are now decoded by their wire's real `Content-Type` instead of a hardcoded assumption. The HTTP server sends the correct type on each response; call sites receiving frames without a header (the byte-oriented NATS transport) pass the type explicitly. - PGP/SSH clearsigned manifests are now accepted: the deck module strips the clearsign framing before verification. - Manifest now emits delete rows for files omitted by the check-in, matching fossil's own behavior. Renames now resolve their parent blob from the pre-rename path to ensure the rename-source blob exists and is reachable. ### Changed - **Breaking:** The module path has changed from `github.com/danmestas/libfossil` to `github.com/danmestas/go-libfossil`. All `replace` directives in `go.mod` have been dropped. Consumers must update their imports and remove any `replace` directives pointing to the old path. - **Breaking:** `StatusOpts`, `MergeOpts`, and `CheckoutOpts` have been removed. No function anywhere accepted any of the three, and nothing constructed one: `Checkout.Status()` takes zero arguments, `Repo.Merge` takes positional string arguments, and `CheckoutOpts` had no construction site at all. A public type with no call site documents a capability that does not exist — a consumer reading `MergeOpts{Strategy: ...}` in the docs could reasonably conclude a strategy-selecting merge API exists; it never did. `Repo.Merge` and `Checkout.Status` keep their current signatures — an options-struct refactor for `Merge` was considered and declined. `CheckoutOpts.Force` was also a third same-named `Force` field in this package, alongside the already-removed `UpdateOpts.Force` and the real, fully-wired `ExtractOpts.Force`; removing it also removes that readability hazard. `ExtractOpts.Force` is unrelated and unaffected. - **Breaking:** `CloneOpts.ProjectCode` and `CloneOpts.ServerCode` have been removed. Neither was ever wired to anything — `Clone` accepted both fields but never forwarded them to the internal clone path, so setting either had no effect and gave no error. The internal clone options struct has no matching fields at all, so wiring them would mean designing semantics first (is a caller-supplied code a validation assertion or an identity override?) and no caller has asked for that. `CloneResult.ProjectCode` and `CloneResult.ServerCode` are unrelated and unaffected — they continue to report both, populated from the remote via the clone protocol negotiation, which is the only place they meaningfully originate. - **Breaking:** `UpdateOpts.Force` has been removed. It was never wired to anything — `Checkout.Update` accepted the field but never forwarded it to the internal update path, so setting it had no effect and gave no error. Deleting it is honest about what the API actually does; real forcing semantics for `Update` can be designed and added later as a new, deliberately-wired field if a caller needs them. `ExtractOpts.Force` is unrelated and unaffected — it is fully wired and unchanged. - **Breaking:** `Checkout.Update` now returns `(UpdateResult, error)` instead of a bare `error`. The internal 3-way merge already tracked which files were written, removed, and left with conflict markers; the old signature discarded all of it, so a caller could not tell a clean update from one that silently wrote `<<<<<<<` conflict markers into working-tree files. `UpdateResult.Conflicted` lists the paths that were merged but not cleanly — this is a successful update (`err == nil`), not an error; a genuine failure still returns a non-nil `error` with a zero-value `UpdateResult`. `Checkout.Extract` is unchanged. - **Breaking:** `Repo.Timeline` now enumerates the repository's `event` table newest-first (every event kind by default, or a single kind via `TimelineOpts.Type`), matching canonical `fossil timeline`. The previous behavior — a first-parent walk from a required start rid — is preserved under a new, honestly-named method, `Repo.Ancestry(LogOpts)`. The old `Repo.Timeline(LogOpts)` was actually an ancestry walk masquerading as an enumeration: it never visited a second parent or a sibling branch head, so it silently omitted any check-in that wasn't a first-parent ancestor of the given start rid. There is no deprecated shim; callers of the old `Timeline` should switch to `Ancestry` if they want the walk, or adopt the new `Timeline(TimelineOpts)` if they want a full enumeration. - `LogEntry` gains a `Kind` field (`EventKind`) identifying which of `event.type`'s six kinds (`ci`, `e`, `f`, `g`, `t`, `w`) an entry is. `Parents` is only populated for `Kind == EventKindCheckin`. - **Breaking:** `Repo.Timeline` orders by `(mtime DESC, rid DESC)`, a total order with rid as a true tie-break at exact mtime equality — a deliberate improvement over canonical fossil's bare `mtime DESC` with no tie-break, which can repeat or skip rows at a page boundary. Pagination uses a new opaque `Cursor` type: take one from a returned `LogEntry.Cursor` and pass it back as `TimelineOpts.After` to resume immediately after that entry. **`TimelineOpts.Before time.Time` and `TimelineOpts.After FslID` are deleted, not deprecated** — callers constructing either field will fail to compile. `Cursor`'s representation is intentionally hidden — it can only be obtained from a `LogEntry`, never built from a timestamp and a rid by hand, because a hand-built cursor derived from a rounded `time.Time` is not guaranteed to match its row exactly, which is what reintroduces skipped or duplicated rows at a page boundary in the first place. - **Breaking:** `LogEntry` no longer has a `Cursor` field, and `Repo.Timeline` now returns `[]TimelineEntry` instead of `[]LogEntry`. `LogEntry` is `Repo.Ancestry`'s result type; its cursor was always the zero value, which is structurally identical to a legitimate Timeline first-page call — so feeding an `Ancestry` entry's cursor into `TimelineOpts.After` silently paginated from page one forever with no error, and documenting the field as invalid on `Ancestry` entries did nothing to stop it. `TimelineEntry` (which embeds `LogEntry` and adds `Cursor Cursor`) is now `Repo.Timeline`'s result type, so the cursor lives only on the type that has one to give. Callers that read `entry.Cursor`, `entry.UUID`, `entry.User`, etc. off a `Repo.Timeline` result need no source change — those fields are still reachable through `TimelineEntry`'s embedded `LogEntry`. Callers that stored a `Repo.Timeline` result as `[]LogEntry` (rather than letting `:=` infer the type, or using `[]TimelineEntry`) will fail to compile. - Performance improvements throughout the sync and manifest subsystems: the phantom-fill crosslink cascade now batches onto a shared content cache, `db.Querier` caches prepared statements to stop per-call SQL re-parse overhead, and delta-chain walks bound their hash-collision chain to prevent quadratic behavior on low-entropy input. History-walking expansions are routed through the content cache, cutting sub-64KiB delta-chain expansion allocation ~18x and bounding `Apply` growth per-command to cut ~5x allocation overhead. ## [0.6.3] - 2026-05-13 ### Fixed - The SQLite DSN now sets `_txlock=immediate`, so writers serialize at `BEGIN` rather than discovering the conflict partway through a transaction (#33). ## [0.6.2] - 2026-05-12 ### Fixed - `Repo.Commit` now preserves the parent check-in's tracked files, instead of dropping files the commit did not itself touch (#30). ## [0.6.1] - 2026-05-12 ### Added - `CreateOpts.ProjectCode` accepts an explicit project code when creating a repository, rather than always generating one (#31). ## [0.6.0] - 2026-05-05 ### Fixed - The WAL is checkpointed on `Close`, so a repository written by this library is readable by canonical fossil without a recovery pass (#28). ## [0.5.0] - 2026-05-04 - Added support for whole-checkin diff via empty filePath parameter. - Added `Repo.UUIDFromRID` for public rid-to-uuid lookup. - Added cross-repo release automation specification and implementation. - Added release workflow with downstream dispatch for automated releases. ## [0.4.5] - 2026-04-30 ### Fixed - A clone against a hub that is being written to concurrently now converges, instead of looping without making progress (#17). ## [0.4.4] - 2026-04-27 ### Fixed - A partial xfer no longer panics with `rid=0`; the incomplete transfer is handled rather than dereferenced (#14). ## [0.4.3] - 2026-04-26 - Stabilized xfer encoder and multi-round sync with deferred manifest crosslink. - Added `libfossil version` command to print build identifier including module version, Go toolchain version, and platform. - Wired live documentation URL into README and hugo baseURL. - Added SVG architecture diagram and SDK refresh. - Launched documentation site and Cloudflare auto-deploy. ## [0.4.2] - 2026-04-26 - Fixed manifest crosslink deferral to handle referenced blobs arriving later. ## [0.4.1] - 2026-04-25 - Implemented xfer encoder and multi-round sync foundation with manifest crosslink. ## [0.4.0] - 2026-04-25 - Added `Repo.Pull` public wrapper with HTTP transport and hostile-input assertions. - Added Tiger Style test coverage for `Checkout.Update`. - Improved documentation and test coverage for `Repo.Pull`. ## [0.3.0] - 2026-04-21 - Added `Repo.ReadFile` for reading tracked file content from the repository at any version. ## [0.2.0] - 2026-04-20 - Added `Repo.Merge` for branch-to-branch 3-way merge operations. - Added `Repo.Diff` for computing diffs between tree states. ## [0.1.0] - 2026-04-20 Initial open-source release of `libfossil`, a pure-Go implementation of the Fossil SCM that reads and writes the same `.fossil` SQLite repository format. ### Added - Repository lifecycle: create new repos and clone from existing ones. - Working-tree operations: checkout and checkin. - Timeline traversal over commits and events. - Merge and rebase primitives. - Diff and annotate (blame) over tracked content. - Manifest parsing and content-addressed blob storage. - Sync protocol client/server for pulling and pushing between repos. - Observer interfaces for sync and checkout, allowing external hooks into both network sync events and working-tree state transitions. - SQLite driver abstraction with support for both `modernc.org/sqlite` (pure Go) and `ncruces/go-sqlite3` (cgo-free, wasm-based) backends. - Deterministic simulation test harness with BUGGIFY-style fault injection for exercising concurrency and failure paths. - OpenTelemetry observer provided as a separate submodule to keep the core dependency footprint small. - `wasip1/wasm` build target for running `libfossil` under WASI runtimes.