| Comment: | fix(sync): ask for phantoms in hash order
buildGimmeCards ranged over the phantoms map, so each round's gimme cards came out in Go's randomised map order. When a round has more phantoms than mxPhantomReq allows, that also picked a random subset to ask for. A seeded simulation then could not replay the same wire, and the docs generator's engine.json (which records a pull's cards) changed between runs, failing the generated-docs check about one run in three. Sort the phantom names before building the cards. Phantom sets are bounded by what the peer announced, so the sort is cheap next to the round trip. |
|---|---|
| Timelines: | family | ancestors | descendants | both | main | trunk |
| Files: | files | file ages | folders |
| SHA3-256: |
82dae665dd9e4a49ddefbb510264fea1 |
| User & Date: | [email protected] on 2026-10-24 00:57:36.000 |
| Other Links: | branch diff | manifest | tags |
|
2026-10-24
| ||
| 01:04 |
Merge pull request #474 from danmestas/fix/deterministic-gimme
fix(sync): ask for phantoms in hash order check-in: d40046f706 user: [email protected] tags: main, trunk | |
| 00:57 |
fix(sync): ask for phantoms in hash order
buildGimmeCards ranged over the phantoms map, so each round's gimme cards came out in Go's randomised map order. When a round has more phantoms than mxPhantomReq allows, that also picked a random subset to ask for. A seeded simulation then could not replay the same wire, and the docs generator's engine.json (which records a pull's cards) changed between runs, failing the generated-docs check about one run in three. Sort the phantom names before building the cards. Phantom sets are bounded by what the peer announced, so the sort is cheap next to the round trip. check-in: 82dae665dd user: [email protected] tags: main, trunk | |
|
2026-10-23
| ||
| 22:10 |
Merge pull request #473 from danmestas/fix/one-docs-build
build(docs): one deploy build, through scripts/docs-build.sh check-in: 5526734cfd user: [email protected] tags: main, trunk | |