Artifact [a29f8f4b1b]

Artifact a29f8f4b1b6528d2e2cec344ce156c9e37732397221973d424d53926082078e8:

• File internal/repo/repo_test.go — part of check-in [f804878bd3] at 2026-07-22 23:58:46 on branch trunk — test: route every fossil-binary gate through one REQUIRE_FOSSIL_BIN helper (#125)

  * test: route fossil-binary tests through one REQUIRE_FOSSIL_BIN helper

  REQUIRE_FOSSIL_BIN=1 turns a missing fossil binary into a test failure instead of an invisible skip, but only internal/manifest honored it. The six other fossil-dependent sites each did their own exec.LookPath + unconditional t.Skip, so on those a run with no fossil was byte-identical to a passing one.

  Add testutil.RequireFossilBin, which resolves the binary the same way FossilBinary does (FOSSIL_BIN override, then PATH) and either skips or fails based on REQUIRE_FOSSIL_BIN. Route testutil.NewTestRepo, both internal/delta CLI round-trips, the four internal/merge validation tests, the internal/xfer sanity check, and the ls-branch-tip repro through it, deleting their bespoke lookup+skip logic. CI already sets REQUIRE_FOSSIL_BIN=1 on the unit-test steps, so this makes all seven sites fail loud on absence while local runs without fossil stay opt-in.

  * test: route every fossil-binary gate through RequireFossilBin

  The first pass left six sites still deciding for themselves whether a missing fossil binary is a skip or a failure. Three of them (internal/sync's startFossilServer and its two integration tests, manifest's two rebuild tests, the root TestPhaseB_Integration, and hash's TestSHA1_FossilValidation) skipped unconditionally, so with REQUIRE_FOSSIL_BIN=1 and no fossil on PATH those packages still reported ok -- the exact silent pass the flag exists to prevent. The other three had hand-rolled copies of the flag check, which is the duplication that let the original drift happen.

  All of them now call testutil.RequireFossilBin, and HasFossil is gone: it was a second, skip-only way to ask the same question, and it is what produced the sites that ignored the flag.

  Also validate the FOSSIL_BIN override with LookPath, so a stale path reports "fossil not found" instead of surfacing later as a raw fork/exec error.

  * test: resolve fossil binary via RequireFossilBin at remaining call sites

  * fix: correct stale module path missed by rebase auto-merge

  Three imports added by earlier commits in this branch predated the rebase target and had no corresponding line on main to conflict against, so git's auto-merge carried the old module path through verbatim. (user: [email protected], size: 3811) [annotate] [blame] [check-ins using]

package repo

import (
	"os/exec"
	"path/filepath"
	"testing"

	"github.com/danmestas/go-libfossil/db"
	_ "github.com/danmestas/go-libfossil/internal/testdriver"
	"github.com/danmestas/go-libfossil/simio"
	"github.com/danmestas/go-libfossil/testutil"
)

func TestCreate(t *testing.T) {
	path := filepath.Join(t.TempDir(), "test.fossil")
	r, err := Create(path, "testuser", simio.CryptoRand{}, "")
	if err != nil {
		t.Fatalf("Create: %v", err)
	}
	defer r.Close()

	if r.Path() != path {
		t.Fatalf("Path = %q, want %q", r.Path(), path)
	}
}

func TestCreate_FossilValidation(t *testing.T) {
	if testing.Short() {
		t.Skip("skipping fossil validation")
	}
	fossilBin := testutil.RequireFossilBin(t)
	path := filepath.Join(t.TempDir(), "test.fossil")
	r, err := Create(path, "testuser", simio.CryptoRand{}, "")
	if err != nil {
		t.Fatalf("Create: %v", err)
	}
	r.Close()

	// fossil rebuild must pass (no --verify flag in Fossil 2.28)
	cmd := exec.Command(fossilBin, "rebuild", path)
	out, err := cmd.CombinedOutput()
	if err != nil {
		t.Fatalf("fossil rebuild failed: %v\n%s", err, out)
	}
}

func TestOpenFossilCreated(t *testing.T) {
	if testing.Short() {
		t.Skip("skipping fossil validation")
	}
	fossilBin := testutil.RequireFossilBin(t)
	path := filepath.Join(t.TempDir(), "fossil-created.fossil")
	cmd := exec.Command(fossilBin, "new", path)
	out, err := cmd.CombinedOutput()
	if err != nil {
		t.Fatalf("fossil new: %v\n%s", err, out)
	}

	r, err := Open(path)
	if err != nil {
		t.Fatalf("Open: %v", err)
	}
	defer r.Close()

	if r.Path() != path {
		t.Fatalf("Path = %q, want %q", r.Path(), path)
	}
}

func TestOpen_NotARepo(t *testing.T) {
	// Create a plain SQLite database with no application_id
	path := filepath.Join(t.TempDir(), "not-a-repo.db")
	d, err := db.Open(path)
	if err != nil {
		t.Fatalf("db.Open: %v", err)
	}
	d.Exec("CREATE TABLE test(x)")
	d.Close()

	_, err = Open(path)
	if err == nil {
		t.Fatal("expected error opening non-repo database")
	}
}

func TestOpen_NonExistent(t *testing.T) {
	_, err := Open("/tmp/nonexistent-repo-12345.fossil")
	if err == nil {
		t.Fatal("expected error opening nonexistent file")
	}
}

func TestWithTx(t *testing.T) {
	path := filepath.Join(t.TempDir(), "test.fossil")
	r, err := Create(path, "testuser", simio.CryptoRand{}, "")
	if err != nil {
		t.Fatalf("Create: %v", err)
	}
	defer r.Close()

	err = r.WithTx(func(tx *db.Tx) error {
		_, err := tx.Exec("INSERT INTO config(name,value,mtime) VALUES('test-key','test-val',0)")
		return err
	})
	if err != nil {
		t.Fatalf("WithTx: %v", err)
	}

	var val string
	r.DB().QueryRow("SELECT value FROM config WHERE name='test-key'").Scan(&val)
	if val != "test-val" {
		t.Fatalf("val = %q, want %q", val, "test-val")
	}
}

func TestRoundTrip_FossilValidation(t *testing.T) {
	if testing.Short() {
		t.Skip("skipping fossil validation")
	}

	fossilBin := testutil.RequireFossilBin(t)

	// 1. fossil creates repo
	fossilPath := filepath.Join(t.TempDir(), "fossil-created.fossil")
	exec.Command(fossilBin, "new", fossilPath).CombinedOutput()

	// 2. Go opens it
	r1, err := Open(fossilPath)
	if err != nil {
		t.Fatalf("Open fossil-created: %v", err)
	}
	r1.Close()

	// 3. Go creates repo
	goPath := filepath.Join(t.TempDir(), "go-created.fossil")
	r2, err := Create(goPath, "testuser", simio.CryptoRand{}, "")
	if err != nil {
		t.Fatalf("Create: %v", err)
	}
	r2.Close()

	// 4. fossil validates Go-created repo
	cmd := exec.Command(fossilBin, "rebuild", goPath)
	out, err := cmd.CombinedOutput()
	if err != nil {
		t.Fatalf("fossil rebuild go-created failed: %v\n%s", err, out)
	}

	// 5. fossil queries Go-created repo
	cmd = exec.Command(fossilBin, "sql", "-R", goPath, "SELECT count(*) FROM blob;")
	out, err = cmd.Output()
	if err != nil {
		t.Fatalf("fossil sql go-created: %v", err)
	}
}