Artifact [fdf701a793]

Artifact fdf701a793da7be05e49dc4bcabf2e541f68300ec00dfb9beae5aaa8fd9b72fb:

• File internal/auth/verify.go — part of check-in [6273a0750d] at 2026-07-22 23:03:24 on branch trunk — fix: correct go.mod module path to go-libfossil (#76) (#117)

  * fix: correct go.mod module path to go-libfossil (#76)

  The module directive still declared github.com/danmestas/libfossil after the repository was renamed to go-libfossil. pkg.go.dev/godoc scraping matches the declared module path against its hosting path, so the stale path broke SDK doc generation.

  Rename the module path across all four in-repo modules (root, the two db/driver submodules, observer/otel, and docs/site) and every internal import, plus the release workflow, the doc-generation script, and the docs.

  No tag has been published under the go-libfossil path yet, so the cross-module requires cannot resolve from the proxy. Add replace directives pointing the in-repo requires at their local directories so GOWORK=off builds and the CI matrix resolve without a published version. These replaces are ignored by downstream consumers and can be dropped once new-path tags are cut.

  * Guard releases against replace directives; regenerate SDK docs

  The go-libfossil rename bridges the in-repo modules with `replace` directives. Go refuses a main module that carries them, so a tag cut while they are present breaks `go install .../cmd/libfossil@<tag>` and every `@version` fetch of the driver submodules. Add a Release workflow step that fails the job before anything is published if any tracked go.mod still contains a replace directive, so the bridge is a CI-enforced TODO rather than a silent landmine. The step comment records what unblocks a release: re-tag the submodules with the corrected module paths, bump the root requires, then drop the replace blocks.

  Regenerate the SDK reference docs. The previous pass only substituted URLs over the pre-existing generated files, leaving stale signatures (Repo.Timeline was still documented as taking LogOpts rather than TimelineOpts). Note that gomarkdoc must be run outside a git worktree — inside one it silently strips every source link.

  Also reword the README rename note, which read as though the import path had not changed, and re-sort the ncruces require block. (user: [email protected], size: 2633) [annotate] [blame] [check-ins using]

package auth

import (
	"crypto/sha1"
	"crypto/subtle"
	"database/sql"
	"encoding/hex"
	"errors"
	"time"

	"github.com/danmestas/go-libfossil/db"
	"github.com/danmestas/go-libfossil/internal/xfer"
)

var ErrAuthFailed = errors.New("authentication failed")

// VerifyLogin validates a login card against the user table.
// The server does NOT need the raw payload — the nonce is in card.Nonce.
// Returns the authenticated User on success, or ErrAuthFailed on any failure.
// Panics if d or card is nil (TigerStyle preconditions).
func VerifyLogin(d *db.DB, projectCode string, card *xfer.LoginCard) (User, error) {
	if d == nil {
		panic("auth.VerifyLogin: d must not be nil")
	}
	if projectCode == "" {
		panic("auth.VerifyLogin: projectCode must not be empty")
	}
	if card == nil {
		panic("auth.VerifyLogin: card must not be nil")
	}

	// 1. Look up user by card.User and retrieve stored password + cexpire
	var storedPW string
	var cexpire sql.NullString
	var u User
	var info sql.NullString
	var mtimeRaw any

	err := d.QueryRow(
		"SELECT uid, login, pw, cap, cexpire, info, mtime FROM user WHERE login=?",
		card.User,
	).Scan(&u.UID, &u.Login, &storedPW, &u.Cap, &cexpire, &info, &mtimeRaw)

	// 2. If not found → ErrAuthFailed
	if err != nil {
		return User{}, ErrAuthFailed
	}

	if info.Valid {
		u.Info = info.String
	}

	// 3. If cexpire is set and in the past → ErrAuthFailed
	if cexpire.Valid {
		// Parse cexpire - SQLite may return either "2006-01-02 15:04:05" or ISO 8601 format
		var expireTime time.Time
		var err error

		// Try ISO 8601 first (SQLite's preferred format)
		expireTime, err = time.Parse(time.RFC3339, cexpire.String)
		if err != nil {
			// Fall back to space-separated format
			expireTime, err = time.Parse("2006-01-02 15:04:05", cexpire.String)
			if err != nil {
				// If we can't parse the expiry, treat it as expired for safety
				return User{}, ErrAuthFailed
			}
		}

		// Check if expired
		if time.Now().After(expireTime) {
			return User{}, ErrAuthFailed
		}

		u.CExpire = expireTime
	}

	// 4. Recompute: expected = SHA1(card.Nonce + storedPW)
	// storedPW is already SHA1(projectCode/login/password) from the user table
	expected := sha1hex([]byte(card.Nonce + storedPW))

	// 5. Compare using crypto/subtle.ConstantTimeCompare
	expectedBytes := []byte(expected)
	signatureBytes := []byte(card.Signature)

	// 6. If mismatch → ErrAuthFailed
	if subtle.ConstantTimeCompare(expectedBytes, signatureBytes) != 1 {
		return User{}, ErrAuthFailed
	}

	// 7. Return User
	return u, nil
}

func sha1hex(data []byte) string {
	h := sha1.Sum(data)
	return hex.EncodeToString(h[:])
}