Artifact c92eec2c736f43d31c581fd62bfd7ded92b09e2672bdfd5c4de2f97105d594ec:
- File
internal/content/chain_bound_test.go
— part of check-in
[6273a0750d]
at
2026-07-22 23:03:24
on branch trunk
— fix: correct go.mod module path to go-libfossil (#76) (#117)
* fix: correct go.mod module path to go-libfossil (#76)
The module directive still declared github.com/danmestas/libfossil after the repository was renamed to go-libfossil. pkg.go.dev/godoc scraping matches the declared module path against its hosting path, so the stale path broke SDK doc generation.
Rename the module path across all four in-repo modules (root, the two db/driver submodules, observer/otel, and docs/site) and every internal import, plus the release workflow, the doc-generation script, and the docs.
No tag has been published under the go-libfossil path yet, so the cross-module requires cannot resolve from the proxy. Add replace directives pointing the in-repo requires at their local directories so GOWORK=off builds and the CI matrix resolve without a published version. These replaces are ignored by downstream consumers and can be dropped once new-path tags are cut.
* Guard releases against replace directives; regenerate SDK docs
The go-libfossil rename bridges the in-repo modules with `replace` directives. Go refuses a main module that carries them, so a tag cut while they are present breaks `go install .../cmd/libfossil@<tag>` and every `@version` fetch of the driver submodules. Add a Release workflow step that fails the job before anything is published if any tracked go.mod still contains a replace directive, so the bridge is a CI-enforced TODO rather than a silent landmine. The step comment records what unblocks a release: re-tag the submodules with the corrected module paths, bump the root requires, then drop the replace blocks.
Regenerate the SDK reference docs. The previous pass only substituted URLs over the pre-existing generated files, leaving stale signatures (Repo.Timeline was still documented as taking LogOpts rather than TimelineOpts). Note that gomarkdoc must be run outside a git worktree — inside one it silently strips every source link.
Also reword the README rename note, which read as though the import path had not changed, and re-sort the ncruces require block. (user: [email protected], size: 2029) [annotate] [blame] [check-ins using]
package content import ( "testing" libfossil "github.com/danmestas/go-libfossil/internal/fsltype" _ "github.com/danmestas/go-libfossil/internal/testdriver" ) // maxDeltaChainDepth's doc says both read-path walks stop after visiting that // many nodes. They reached the bound a node apart until the loop in // walkDeltaChain was rewritten to count nodes rather than iterations, which // meant a chain of exactly maxDeltaChainDepth+1 was unavailable to one walk // and complete to the other. Nothing else pins the two together: each has its // own loop, and a future edit to either can reintroduce the skew silently. func TestChainBoundBitesAtSameLength(t *testing.T) { for _, n := range []int{maxDeltaChainDepth, maxDeltaChainDepth + 1} { d := setupTestDB(t) rids := make([]libfossil.FslID, n) for i := 0; i < n; i++ { res, err := d.Exec( "INSERT INTO blob(uuid, size, content, rcvid) VALUES(printf('%040d', ?), 42, x'00', 1)", i) if err != nil { t.Fatalf("insert blob %d: %v", i, err) } id, err := res.LastInsertId() if err != nil { t.Fatalf("LastInsertId: %v", err) } rids[i] = libfossil.FslID(id) } // An acyclic chain grounded at its far end, so only the bound can // decide the outcome. for i := 0; i < n-1; i++ { if _, err := d.Exec("INSERT INTO delta(rid, srcid) VALUES(?, ?)", rids[i], rids[i+1]); err != nil { t.Fatalf("insert delta %d: %v", i, err) } } available := IsAvailable(d, rids[0]) _, _, err := walkDeltaChain(d, rids[0], nil) walked := err == nil if available != walked { t.Errorf("chain of %d nodes: IsAvailable=%v but walkDeltaChain succeeded=%v; "+ "the two walks must reach maxDeltaChainDepth (%d) at the same length", n, available, walked, maxDeltaChainDepth) } if n == maxDeltaChainDepth && !available { t.Errorf("chain of exactly maxDeltaChainDepth (%d) nodes was rejected", n) } if n == maxDeltaChainDepth+1 && available { t.Errorf("chain of maxDeltaChainDepth+1 (%d) nodes was accepted", n) } } }