Artifact 8e77ebb19f8392440dc7a982f7449293ebf091fe1090896b075339888a90f26b:
- File
internal/search/search.go
— part of check-in
[6273a0750d]
at
2026-07-22 23:03:24
on branch trunk
— fix: correct go.mod module path to go-libfossil (#76) (#117)
* fix: correct go.mod module path to go-libfossil (#76)
The module directive still declared github.com/danmestas/libfossil after the repository was renamed to go-libfossil. pkg.go.dev/godoc scraping matches the declared module path against its hosting path, so the stale path broke SDK doc generation.
Rename the module path across all four in-repo modules (root, the two db/driver submodules, observer/otel, and docs/site) and every internal import, plus the release workflow, the doc-generation script, and the docs.
No tag has been published under the go-libfossil path yet, so the cross-module requires cannot resolve from the proxy. Add replace directives pointing the in-repo requires at their local directories so GOWORK=off builds and the CI matrix resolve without a published version. These replaces are ignored by downstream consumers and can be dropped once new-path tags are cut.
* Guard releases against replace directives; regenerate SDK docs
The go-libfossil rename bridges the in-repo modules with `replace` directives. Go refuses a main module that carries them, so a tag cut while they are present breaks `go install .../cmd/libfossil@<tag>` and every `@version` fetch of the driver submodules. Add a Release workflow step that fails the job before anything is published if any tracked go.mod still contains a replace directive, so the bridge is a CI-enforced TODO rather than a silent landmine. The step comment records what unblocks a release: re-tag the submodules with the corrected module paths, bump the root requires, then drop the replace blocks.
Regenerate the SDK reference docs. The previous pass only substituted URLs over the pre-existing generated files, leaving stale signatures (Repo.Timeline was still documented as taking LogOpts rather than TimelineOpts). Note that gomarkdoc must be run outside a git worktree — inside one it silently strips every source link.
Also reword the README rename note, which read as though the import path had not changed, and re-sort the ncruces require block. (user: [email protected], size: 2219) [annotate] [blame] [check-ins using]
package search import ( "fmt" "github.com/danmestas/go-libfossil/internal/repo" ) // Index manages the FTS5 trigram index in a repo DB. type Index struct { repo *repo.Repo } // Open creates an Index from an open repo. Creates FTS5 tables if they don't exist. // // Panics if r is nil (TigerStyle precondition). func Open(r *repo.Repo) (*Index, error) { if r == nil { panic("search.Open: nil *repo.Repo") } if err := ensureSchema(r); err != nil { return nil, fmt.Errorf("search.Open: %w", err) } return &Index{repo: r}, nil } // Drop removes the FTS tables entirely. func (idx *Index) Drop() error { if idx == nil { panic("search.Drop: nil *Index") } db := idx.repo.DB() for _, stmt := range []string{ "DROP TABLE IF EXISTS fts_content", "DROP TABLE IF EXISTS fts_meta", } { if _, err := db.Exec(stmt); err != nil { return fmt.Errorf("search.Drop: %w", err) } } return nil } // ensureSchema creates FTS5 and metadata tables if they don't already exist. // Idempotent — safe to call on every Open because CREATE IF NOT EXISTS is a no-op // when tables are present, avoiding the need for a separate migration path. func ensureSchema(r *repo.Repo) error { db := r.DB() stmts := []string{ `CREATE VIRTUAL TABLE IF NOT EXISTS fts_content USING fts5( path, content, tokenize='trigram' )`, `CREATE TABLE IF NOT EXISTS fts_meta( key TEXT PRIMARY KEY, value TEXT )`, } for _, stmt := range stmts { if _, err := db.Exec(stmt); err != nil { return fmt.Errorf("ensureSchema: %w", err) } } return nil } // Query configures a search request. type Query struct { Term string // search term (min 3 chars, FTS5 special chars escaped internally) MaxResults int // 0 → default (50) ContextLines int // lines of surrounding context (0 → just the match line) } // Result is a single search hit. type Result struct { Path string // file pathname Line int // 1-based line number Column int // 0-based byte offset within the line MatchLen int // length of matched substring LineText string // the matching line Context string // surrounding lines including match line, newline-separated. Empty if ContextLines=0. }