Artifact 67bf9fee4d3f23a54349a6b11af89d90043c666ac3ce7c2ee2b442234f0ca489:
- File
internal/manifest/fossilbin_test.go
— part of check-in
[6273a0750d]
at
2026-07-22 23:03:24
on branch trunk
— fix: correct go.mod module path to go-libfossil (#76) (#117)
* fix: correct go.mod module path to go-libfossil (#76)
The module directive still declared github.com/danmestas/libfossil after the repository was renamed to go-libfossil. pkg.go.dev/godoc scraping matches the declared module path against its hosting path, so the stale path broke SDK doc generation.
Rename the module path across all four in-repo modules (root, the two db/driver submodules, observer/otel, and docs/site) and every internal import, plus the release workflow, the doc-generation script, and the docs.
No tag has been published under the go-libfossil path yet, so the cross-module requires cannot resolve from the proxy. Add replace directives pointing the in-repo requires at their local directories so GOWORK=off builds and the CI matrix resolve without a published version. These replaces are ignored by downstream consumers and can be dropped once new-path tags are cut.
* Guard releases against replace directives; regenerate SDK docs
The go-libfossil rename bridges the in-repo modules with `replace` directives. Go refuses a main module that carries them, so a tag cut while they are present breaks `go install .../cmd/libfossil@<tag>` and every `@version` fetch of the driver submodules. Add a Release workflow step that fails the job before anything is published if any tracked go.mod still contains a replace directive, so the bridge is a CI-enforced TODO rather than a silent landmine. The step comment records what unblocks a release: re-tag the submodules with the corrected module paths, bump the root requires, then drop the replace blocks.
Regenerate the SDK reference docs. The previous pass only substituted URLs over the pre-existing generated files, leaving stale signatures (Repo.Timeline was still documented as taking LogOpts rather than TimelineOpts). Note that gomarkdoc must be run outside a git worktree — inside one it silently strips every source link.
Also reword the README rename note, which read as though the import path had not changed, and re-sort the ncruces require block. (user: [email protected], size: 2666) [annotate] [blame] [check-ins using]
package manifest import ( "os" "os/exec" "path/filepath" "strings" "testing" "github.com/danmestas/go-libfossil/internal/repo" "github.com/danmestas/go-libfossil/simio" ) // TestFossilBinaryReadsDeltifiedRepo is the acceptance check that our own // tests cannot provide: a repository we wrote, with delta chains produced by // the commit path, must be readable by canonical Fossil. `fossil rebuild` // re-derives every table from the blob content, so it expands every artifact // and re-verifies each against its UUID -- if any delta we wrote were // malformed or linked wrongly, it fails there. func TestFossilBinaryReadsDeltifiedRepo(t *testing.T) { // A skip is invisible without -v, so a run with no fossil binary would // otherwise be byte-identical to a passing one -- for the single // criterion our own tests cannot substitute for. CI sets // REQUIRE_FOSSIL_BIN=1 to turn a missing binary into a failure. bin, err := exec.LookPath("fossil") if err != nil { if os.Getenv("REQUIRE_FOSSIL_BIN") == "1" { t.Fatalf("REQUIRE_FOSSIL_BIN=1 but no fossil binary on PATH: %v", err) } t.Skip("fossil binary not on PATH; cannot verify canonical readability") } path := filepath.Join(t.TempDir(), "deltified.fossil") r, err := repo.Create(path, "testuser", simio.CryptoRand{}, "") if err != nil { t.Fatalf("repo.Create: %v", err) } incrementalHistory(t, r, 4, 12, 400) s := collectStorageStats(t, r) if s.deltaEncoded == 0 { t.Fatal("no deltas were produced; this test would prove nothing") } if err := r.Close(); err != nil { t.Fatalf("repo.Close: %v", err) } run := func(args ...string) string { t.Helper() out, err := exec.Command(bin, args...).CombinedOutput() t.Logf("fossil %s:\n%s", strings.Join(args, " "), out) if err != nil { t.Fatalf("fossil %s failed: %v", strings.Join(args, " "), err) } return string(out) } // test-integrity expands every non-phantom blob and compares the result // against its UUID. Run it before rebuild, while the file still holds // exactly the bytes we wrote. integrity := run("test-integrity", "-R", path) if !strings.Contains(integrity, "0 errors") { t.Fatalf("fossil test-integrity did not report 0 errors") } if !strings.Contains(integrity, "low-level database integrity-check: ok") { t.Fatalf("fossil reported a low-level database problem") } // rebuild re-derives every table from blob content, which means walking // each delta chain we produced. It verifies the BLOB table unless // --noverify is given. stats := run("rebuild", path, "--stats") if !strings.Contains(stats, "Artifacts:") { t.Fatalf("fossil rebuild produced no statistics") } }