Artifact 59847a1479d1e67e3023e2af9da0d0a7de7bc7bf678149ca41b36b40eb3b3083:
- File
db/schema_test.go
— part of check-in
[6273a0750d]
at
2026-07-22 23:03:24
on branch trunk
— fix: correct go.mod module path to go-libfossil (#76) (#117)
* fix: correct go.mod module path to go-libfossil (#76)
The module directive still declared github.com/danmestas/libfossil after the repository was renamed to go-libfossil. pkg.go.dev/godoc scraping matches the declared module path against its hosting path, so the stale path broke SDK doc generation.
Rename the module path across all four in-repo modules (root, the two db/driver submodules, observer/otel, and docs/site) and every internal import, plus the release workflow, the doc-generation script, and the docs.
No tag has been published under the go-libfossil path yet, so the cross-module requires cannot resolve from the proxy. Add replace directives pointing the in-repo requires at their local directories so GOWORK=off builds and the CI matrix resolve without a published version. These replaces are ignored by downstream consumers and can be dropped once new-path tags are cut.
* Guard releases against replace directives; regenerate SDK docs
The go-libfossil rename bridges the in-repo modules with `replace` directives. Go refuses a main module that carries them, so a tag cut while they are present breaks `go install .../cmd/libfossil@<tag>` and every `@version` fetch of the driver submodules. Add a Release workflow step that fails the job before anything is published if any tracked go.mod still contains a replace directive, so the bridge is a CI-enforced TODO rather than a silent landmine. The step comment records what unblocks a release: re-tag the submodules with the corrected module paths, bump the root requires, then drop the replace blocks.
Regenerate the SDK reference docs. The previous pass only substituted URLs over the pre-existing generated files, leaving stale signatures (Repo.Timeline was still documented as taking LogOpts rather than TimelineOpts). Note that gomarkdoc must be run outside a git worktree — inside one it silently strips every source link.
Also reword the README rename note, which read as though the import path had not changed, and re-sort the ncruces require block. (user: [email protected], size: 1889) [annotate] [blame] [check-ins using]
package db_test import ( "path/filepath" "testing" "github.com/danmestas/go-libfossil/db" _ "github.com/danmestas/go-libfossil/internal/testdriver" ) func TestSeedNobody(t *testing.T) { path := filepath.Join(t.TempDir(), "test.fossil") d, err := db.Open(path) if err != nil { t.Fatalf("Open: %v", err) } defer d.Close() if err := db.CreateRepoSchema(d); err != nil { t.Fatalf("CreateRepoSchema: %v", err) } if err := db.SeedNobody(d, "oi"); err != nil { t.Fatalf("SeedNobody: %v", err) } var login, cap string err = d.QueryRow("SELECT login, cap FROM user WHERE login='nobody'").Scan(&login, &cap) if err != nil { t.Fatalf("nobody user not found: %v", err) } if cap != "oi" { t.Errorf("cap = %q, want oi", cap) } } // TestCreateRepoSchemaTicketTables asserts that a newly created repository // provisions the ticket, ticketchng tables and the ticketchng_idx1 index, // matching what canonical `fossil new` produces. Stock Fossil's web UI // queries the ticket table unconditionally (e.g. the artifact-prefix lookup // behind /info/<uuid>), so a repo missing this schema crashes stock tooling. func TestCreateRepoSchemaTicketTables(t *testing.T) { path := filepath.Join(t.TempDir(), "test.fossil") d, err := db.Open(path) if err != nil { t.Fatalf("Open: %v", err) } defer d.Close() if err := db.CreateRepoSchema(d); err != nil { t.Fatalf("CreateRepoSchema: %v", err) } for _, tbl := range []string{"ticket", "ticketchng"} { var name string err := d.QueryRow( "SELECT name FROM sqlite_master WHERE type='table' AND name=?", tbl, ).Scan(&name) if err != nil { t.Errorf("table %q not found: %v", tbl, err) } } var idxName string err = d.QueryRow( "SELECT name FROM sqlite_master WHERE type='index' AND name='ticketchng_idx1'", ).Scan(&idxName) if err != nil { t.Errorf("index ticketchng_idx1 not found: %v", err) } }