Artifact [51374fff02]

Artifact 51374fff0201f68637e5e6de9f92888c87be74d92c68eeeaff1294817571759d:

• File conformance/repostate_gaps_test.go — part of check-in [faf47b6220] at 2026-10-11 23:06:08 on branch main — fix(branch): refuse an open branch's name on create; close a branch by its tip (#292) (#317)

  branch.Create accepted a name an open branch already used, letting a second branch of the same name be created; and branch.List marked a branch closed when any check-in on it carried a closed tag, so closing a non-tip check-in hid an open branch.

  Create now checks branch_is_open first (an open leaf whose active branch is the name) and refuses before building any artifact, so nothing is stored on refusal, matching `fossil branch new`. The check uses fossil's exact tag types: a propagating branch tag (tagtype=2) and a singleton closed tag (tagtype=1). List now derives a branch's closed state from its newest check-in's closed tag, the row fossil's branch-list query reads, so a branch with an open tip lists open. Unit tests cover the refusal, the no-stored-blob guarantee and reuse of a closed branch's name. (user: [email protected], size: 4499) [annotate] [blame] [check-ins using]

package conformance

import "testing"

// repostateGaps marks the repository-state cases go-libfossil is known to
// fail, by case ID, grouped by the code at fault, each with the issue
// tracking its fix.
var repostateGaps = map[string]string{
	// verify.Rebuild derives only check-ins and control artifacts: no
	// cluster tag, no technote tags (verify/rebuild_tags.go:47, :65); it
	// applies a control artifact the crosslink would refuse, having no
	// isArtifact gate (:56-70); it skips an absent tag target and an absent
	// parent rather than making a phantom (:124, rebuild_manifest.go:114); it
	// writes no plink baseline (rebuild_manifest.go:131); and its leaf rule
	// is "no child at all", whatever the branch (rebuild_leaves.go:16-21).
	"repostate.4.2.cluster.rebuild":           "#285",
	"repostate.4.2.technote-tags.rebuild":     "#285",
	"repostate.4.4.opaque-control.rebuild":    "#285",
	"repostate.4.2.phantom-target.rebuild":    "#285",
	"repostate.4.2.phantom-parent.rebuild":    "#285",
	"repostate.3.1.link-metadata.rebuild":     "#285",
	"repostate.7.2.branch-leaves.rebuild":     "#285",
	"repostate.7.6.retag-branch.rebuild":      "#285",
	"repostate.7.6.propagated-branch.rebuild": "#285",
	// A root check-in's file rows are inserted with no "already derived"
	// guard, so crosslinking it again adds a second copy of each
	// (internal/manifest/addmlink.go:605-612).
	"repostate.4.2.relink-unchanged": "#294",
	// No parent (reparent) tag handling in the crosslink, tag or rebuild
	// code: plink keeps the old parent.
	"repostate.4.2.reparent":         "#286",
	"repostate.4.2.reparent.rebuild": "#286",
	// blob.Store returns a phantom's rid as if the content were stored: its
	// existingName takes any row blob.Exists finds, phantoms included
	// (internal/blob/blob.go:23), so an artifact that arrives after being
	// referenced is never stored or crosslinked.
	"repostate.4.2.phantom-late-target": "#278",
	// isArtifact accepts a technote with a T-card naming another artifact
	// (internal/manifest/crosslink.go:583), and crosslinkEvent applies it
	// (:1510).
	"repostate.12.technote-non-self": "#287",
	// The cancel walk deletes an inherited row whatever its mtime: the query
	// is COALESCE(srcid=0, 0), without AND tagxref.mtime < ? (tag/propagate.go:67).
	"repostate.5.4.cancel-skips-newer-inherited": "#288",
	// manifest.Checkin writes the first check-in's sym-trunk as a singleton,
	// +sym-trunk, where fossil(1) and Section 6.1 write *sym-trunk
	// (internal/manifest/manifest.go:226).
	"repostate.6.1.initial-sym": "#289",
	// ResolveVersion (repo_history.go:267-350) orders by tagxref.mtime, not
	// event.mtime (:291, :310); falls back to tip when no check-in carries
	// sym-trunk (:299); tries a name before a hash prefix (:300-320); and has
	// no rid:, tag:, root:, start:, merge-in: or NAME:TIMESTAMP form and no
	// trailing-punctuation retry.
	"repostate.8.2.event-mtime":      "#290",
	"repostate.8.2.trunk-chain":      "#290",
	"repostate.8.2.not-leaf":         "#290",
	"repostate.8.2.no-trunk-sym":     "#290",
	"repostate.8.3.hash-before-name": "#290",
	"repostate.8.3.rid":              "#290",
	"repostate.8.3.tag-prefix":       "#290",
	"repostate.8.3.root":             "#290",
	"repostate.8.3.start":            "#290",
	"repostate.8.3.merge-in":         "#290",
	"repostate.8.3.name-timestamp":   "#290",
	"repostate.8.3.trailing-punct":   "#290",
	// Repo.Tag stores the name as given: no sym- prefix, no refusal of the
	// reserved wiki-, tkt- and event- prefixes (repo_extras.go:39-46,
	// internal/tag/tag.go:45).
	"repostate.2.sym-prefix":      "#293",
	"repostate.2.reserved-prefix": "#293",
}

// repostateDeviations marks the cases where go-libfossil follows fossil(1)
// rather than the draft text, by case ID.
var repostateDeviations = map[string]string{
	"repostate.7.3.parentless-untagged": "follows fossil(1): an untagged parentless " +
		"check-in is never a leaf, where Section 7.3 makes every check-in without a " +
		"same-branch child one (erratum candidate)",
}

// TestRepoStateGapKeys checks that every marked case exists.
func TestRepoStateGapKeys(t *testing.T) {
	ids := map[string]bool{}
	for _, c := range repostateSuiteCases() {
		ids[c.ID] = true
	}
	for id := range repostateGaps {
		if !ids[id] {
			t.Errorf("repostateGaps names %s, which is not a case", id)
		}
	}
	for id := range repostateDeviations {
		if !ids[id] {
			t.Errorf("repostateDeviations names %s, which is not a case", id)
		}
	}
}