Artifact [4b8819f866]

Artifact 4b8819f8666a6bc78ee053b27d802f04aa68f77aece01808efd646c10115889c:

• File internal/verify/check_structure.go — part of check-in [6273a0750d] at 2026-07-22 23:03:24 on branch trunk — fix: correct go.mod module path to go-libfossil (#76) (#117)

  * fix: correct go.mod module path to go-libfossil (#76)

  The module directive still declared github.com/danmestas/libfossil after the repository was renamed to go-libfossil. pkg.go.dev/godoc scraping matches the declared module path against its hosting path, so the stale path broke SDK doc generation.

  Rename the module path across all four in-repo modules (root, the two db/driver submodules, observer/otel, and docs/site) and every internal import, plus the release workflow, the doc-generation script, and the docs.

  No tag has been published under the go-libfossil path yet, so the cross-module requires cannot resolve from the proxy. Add replace directives pointing the in-repo requires at their local directories so GOWORK=off builds and the CI matrix resolve without a published version. These replaces are ignored by downstream consumers and can be dropped once new-path tags are cut.

  * Guard releases against replace directives; regenerate SDK docs

  The go-libfossil rename bridges the in-repo modules with `replace` directives. Go refuses a main module that carries them, so a tag cut while they are present breaks `go install .../cmd/libfossil@<tag>` and every `@version` fetch of the driver submodules. Add a Release workflow step that fails the job before anything is published if any tracked go.mod still contains a replace directive, so the bridge is a CI-enforced TODO rather than a silent landmine. The step comment records what unblocks a release: re-tag the submodules with the corrected module paths, bump the root requires, then drop the replace blocks.

  Regenerate the SDK reference docs. The previous pass only substituted URLs over the pre-existing generated files, leaving stale signatures (Repo.Timeline was still documented as taking LogOpts rather than TimelineOpts). Note that gomarkdoc must be run outside a git worktree — inside one it silently strips every source link.

  Also reword the README rename note, which read as though the import path had not changed, and re-sort the ncruces require block. (user: [email protected], size: 2046) [annotate] [blame] [check-ins using]

package verify

import (
	"fmt"

	libfossil "github.com/danmestas/go-libfossil/internal/fsltype"
	"github.com/danmestas/go-libfossil/internal/repo"
)

// checkDeltaChains verifies delta relationships are valid.
// Detects dangling references: delta rows pointing to nonexistent blobs.
func checkDeltaChains(r *repo.Repo, report *Report) error {
	if r == nil {
		panic("checkDeltaChains: nil *repo.Repo")
	}
	if report == nil {
		panic("checkDeltaChains: nil *Report")
	}

	rows, err := r.DB().Query(`
		SELECT d.rid, d.srcid FROM delta d
		WHERE NOT EXISTS (SELECT 1 FROM blob WHERE rid = d.rid)
		   OR NOT EXISTS (SELECT 1 FROM blob WHERE rid = d.srcid)
	`)
	if err != nil {
		return fmt.Errorf("checkDeltaChains: query: %w", err)
	}
	defer rows.Close()

	for rows.Next() {
		var rid, srcid int64
		if err := rows.Scan(&rid, &srcid); err != nil {
			return fmt.Errorf("checkDeltaChains: scan: %w", err)
		}
		report.addIssue(Issue{
			Kind:    IssueDeltaDangling,
			RID:     libfossil.FslID(rid),
			UUID:    "",
			Table:   "delta",
			Message: fmt.Sprintf("delta rid=%d srcid=%d: one or both blobs missing", rid, srcid),
		})
	}
	return rows.Err()
}

// checkPhantoms verifies phantom records are properly tracked.
// Detects orphan phantoms: phantom rows with no corresponding blob.
func checkPhantoms(r *repo.Repo, report *Report) error {
	if r == nil {
		panic("checkPhantoms: nil *repo.Repo")
	}
	if report == nil {
		panic("checkPhantoms: nil *Report")
	}

	rows, err := r.DB().Query(`
		SELECT p.rid FROM phantom p
		WHERE NOT EXISTS (SELECT 1 FROM blob WHERE rid = p.rid)
	`)
	if err != nil {
		return fmt.Errorf("checkPhantoms: query: %w", err)
	}
	defer rows.Close()

	for rows.Next() {
		var rid int64
		if err := rows.Scan(&rid); err != nil {
			return fmt.Errorf("checkPhantoms: scan: %w", err)
		}
		report.addIssue(Issue{
			Kind:    IssuePhantomOrphan,
			RID:     libfossil.FslID(rid),
			UUID:    "",
			Table:   "phantom",
			Message: fmt.Sprintf("phantom rid=%d: no corresponding blob", rid),
		})
	}
	return rows.Err()
}