Artifact 4af88c119100221efd66230957225376c64a6d7266ca91f2ca456c432c56fe24:
- File
internal/repo/repo.go
— part of check-in
[c5f5838169]
at
2026-10-13 14:09:47
on branch main
— fix(sync): run each request, reply and clone round in one transaction (#422)
A received delta found wrong when its basis arrives later in the pass fails sync-protocol-01 Section 7.7's commit check, which now rolls back everything the pass stored, as fossil's page_xfer and client_sync transactions do, instead of undoing the delta by hand and keeping the rest. The phantom-fill cascades and the server's closing leaf and tag repair run inside that transaction. Any other card error still commits the prefix before it (Section 10.1); on the client that prefix now includes the reply's buffered igot phantoms and visibility changes.
db.DB.WithBoundTx binds a DB to one write transaction so code written against *DB, nested WithTx included, joins it as savepoints instead of contending for the write lock from a second connection.
SP-7.7-4 is covered; the new SP-10.1-6 has sync.10.1.integrity-error-prefix. Tracked in #418. (user: [email protected], size: 8096) [annotate] [blame] [check-ins using]
package repo import ( "fmt" "strconv" "github.com/danmestas/go-libfossil/db" "github.com/danmestas/go-libfossil/internal/content" libfossil "github.com/danmestas/go-libfossil/internal/fsltype" "github.com/danmestas/go-libfossil/internal/hash" "github.com/danmestas/go-libfossil/simio" ) type Repo struct { db *db.DB path string } // Create creates a new repo at path, seeded with the given user. // If projectCode is empty, a fresh project-code is generated; otherwise // projectCode must already be valid (40-char lowercase hex) — validation // is enforced at the libfossil.Create boundary. func Create(path string, user string, rng simio.Rand, projectCode string) (*Repo, error) { env := simio.RealEnv() env.Rand = rng return CreateWithEnv(path, user, env, projectCode) } func CreateWithEnv(path string, user string, env *simio.Env, projectCode string) (*Repo, error) { if path == "" { panic("repo.CreateWithEnv: path must not be empty") } if env == nil { env = simio.RealEnv() } if env.Rand == nil { panic("repo.CreateWithEnv: env.Rand must not be nil") } if env.Storage == nil { env.Storage = simio.OSStorage{} } if _, err := env.Storage.Stat(path); err == nil { return nil, fmt.Errorf("repo.CreateWithEnv: file already exists: %s", path) } d, err := db.Open(path) if err != nil { return nil, fmt.Errorf("repo.CreateWithEnv open: %w", err) } if err := db.CreateRepoSchema(d); err != nil { d.Close() if rmErr := env.Storage.Remove(path); rmErr != nil { return nil, fmt.Errorf("repo.CreateWithEnv: %w (cleanup failed: %v)", err, rmErr) } return nil, fmt.Errorf("repo.CreateWithEnv schema: %w", err) } if err := db.SeedUser(d, user); err != nil { d.Close() if rmErr := env.Storage.Remove(path); rmErr != nil { return nil, fmt.Errorf("repo.CreateWithEnv: %w (cleanup failed: %v)", err, rmErr) } return nil, fmt.Errorf("repo.CreateWithEnv seed user: %w", err) } if err := db.SeedConfig(d, env.Rand, projectCode); err != nil { d.Close() if rmErr := env.Storage.Remove(path); rmErr != nil { return nil, fmt.Errorf("repo.CreateWithEnv: %w (cleanup failed: %v)", err, rmErr) } return nil, fmt.Errorf("repo.CreateWithEnv seed config: %w", err) } // After SeedConfig, so a seeded Rand still yields the project and server // codes it did before these users were added. if err := db.SeedDefaultUsers(d, env.Rand); err != nil { d.Close() if rmErr := env.Storage.Remove(path); rmErr != nil { return nil, fmt.Errorf("repo.CreateWithEnv: %w (cleanup failed: %v)", err, rmErr) } return nil, fmt.Errorf("repo.CreateWithEnv seed default users: %w", err) } return &Repo{db: d, path: path}, nil } func Open(path string) (*Repo, error) { return OpenWithEnv(path, nil) } func OpenWithEnv(path string, env *simio.Env) (*Repo, error) { if path == "" { panic("repo.OpenWithEnv: path must not be empty") } if env == nil { env = simio.RealEnv() } if env.Storage == nil { env.Storage = simio.OSStorage{} } if err := checkExists(env, path); err != nil { return nil, fmt.Errorf("repo.OpenWithEnv: %w", err) } d, err := db.Open(path) if err != nil { return nil, fmt.Errorf("repo.OpenWithEnv: %w", err) } id, err := d.ApplicationID() if err != nil { d.Close() return nil, fmt.Errorf("repo.OpenWithEnv application_id: %w", err) } if id != libfossil.FossilApplicationID { d.Close() return nil, fmt.Errorf("repo.OpenWithEnv: not a fossil repo (application_id=%d, want %d)", id, libfossil.FossilApplicationID) } return &Repo{db: d, path: path}, nil } func (r *Repo) Close() error { return r.db.Close() } // Checkpoint runs PRAGMA wal_checkpoint(<mode>) against the repo's database. // See db.DB.Checkpoint for semantics. func (r *Repo) Checkpoint(mode db.CheckpointMode) error { return r.db.Checkpoint(mode) } func (r *Repo) Path() string { return r.path } func (r *Repo) DB() *db.DB { return r.db } func (r *Repo) WithTx(fn func(tx *db.Tx) error) error { return r.db.WithTx(fn) } // WithBoundTx runs fn in one write transaction with a Repo bound to it, as // db.DB.WithBoundTx binds its DB: everything fn does through that Repo, // including the transactions code running on it opens, commits together when // fn returns nil and rolls back together otherwise. The bound Repo is valid // only until fn returns and must not be closed. func (r *Repo) WithBoundTx(fn func(bound *Repo) error) error { if fn == nil { panic("repo.WithBoundTx: fn must not be nil") } return r.db.WithBoundTx(func(b *db.DB) error { return fn(&Repo{db: b, path: r.path}) }) } // Config reads a configuration value from the repo's config table. func (r *Repo) Config(key string) (string, error) { var value string err := r.db.QueryRow("SELECT value FROM config WHERE name=?", key).Scan(&value) if err != nil { return "", fmt.Errorf("repo.Config %q: %w", key, err) } return value, nil } // UUIDByRID returns the UUID (manifest hash) of the artifact with the given // rid by querying the blob table. Returns sql.ErrNoRows (wrapped) when no // blob row exists for the rid. func (r *Repo) UUIDByRID(rid int64) (string, error) { var uuid string err := r.db.QueryRow("SELECT uuid FROM blob WHERE rid=?", rid).Scan(&uuid) if err != nil { return "", fmt.Errorf("repo.UUIDByRID rid=%d: %w", rid, err) } return uuid, nil } // SetConfig writes a configuration value to the repo's config table. // // A hash-policy value must be one of the ordinals 0 through 4, the only form // the reader accepts (AF-7.1-2). Fossil makes an unknown policy fatal where // the value comes in (hname.c hash_policy_command), so a bad value is refused // here instead of poisoning every later store. func (r *Repo) SetConfig(key, value string) error { if key == "hash-policy" { if n, err := strconv.Atoi(value); err != nil || n < 0 || n > 4 { return fmt.Errorf("repo.SetConfig: hash-policy %q is not a policy ordinal (0-4)", value) } } _, err := r.db.Exec( "INSERT OR REPLACE INTO config(name, value, mtime) VALUES(?, ?, julianday('now'))", key, value, ) if err != nil { return fmt.Errorf("repo.SetConfig %q: %w", key, err) } return nil } // SetHashPolicy assigns the hash policy by its value string, as fossil's // hash-policy command does: name must be one of sha1, auto, sha3, sha3-only // or shun-sha1, matched case-sensitively and exactly, and anything else is // an error that leaves the stored policy alone (artifact-format-01 7.1, // AF-7.1-2). The ordinal is what is stored, the form the reader takes. // // Asking for auto in a repo that already holds a SHA3 artifact stores sha3 // (7.3, set-time coercion): auto would be promoted by the first SHA3 store // anyway, and fossil's command coerces the same way. func (r *Repo) SetHashPolicy(name string) error { if r == nil { panic("repo.SetHashPolicy: receiver must not be nil") } policy, err := hash.PolicyByName(name) if err != nil { return fmt.Errorf("repo.SetHashPolicy: %w", err) } if policy != db.HashPolicyAuto { return r.SetConfig("hash-policy", strconv.Itoa(policy)) } // The SHA3 check and the write are one statement, so a SHA3 artifact // stored concurrently cannot slip between them and have the write undo // the ratchet (7.3). _, err = r.db.Exec( "INSERT OR REPLACE INTO config(name, value, mtime) VALUES('hash-policy', "+ "CASE WHEN EXISTS(SELECT 1 FROM blob WHERE length(uuid)>40) THEN ? ELSE ? END, "+ "julianday('now'))", strconv.Itoa(db.HashPolicySHA3), strconv.Itoa(db.HashPolicyAuto), ) if err != nil { return fmt.Errorf("repo.SetHashPolicy: %w", err) } return nil } func (r *Repo) Verify() error { if r == nil { panic("repo.Verify: receiver must not be nil") } rows, err := r.db.Query("SELECT rid FROM blob WHERE size >= 0") if err != nil { return fmt.Errorf("repo.Verify query: %w", err) } defer rows.Close() for rows.Next() { var rid int64 if err := rows.Scan(&rid); err != nil { return fmt.Errorf("repo.Verify scan: %w", err) } if err := content.Verify(r.db, libfossil.FslID(rid)); err != nil { return err } } return rows.Err() }