Artifact [41892b8f45]

Artifact 41892b8f453efb40fbda5f1cf2700e1c345a1e164a24a48cfceb7995c813eb3d:

• File ssh_dependency_test.go — part of check-in [9594cf3bae] at 2026-10-29 03:06:23 on branch main — perf(wasm): add a libfossil_nohttp build tag that leaves out net/http

  Under TinyGo, importing net/http at all links its TLS and X.509 code (crypto/x509, encoding/asn1, math/big's integers, AES-GCM, SHA-3, netip) whether or not a request is ever made: a five-line program that calls only http.StatusText grows by about 430 KB raw. The library imports it for its HTTP client transport and its HTTP server, which a program that serves sync through HandleSyncWithOpts and supplies its own transport never calls.

  Built with -tags libfossil_nohttp, the library leaves out NewHTTPTransport, WithHTTPClient, Repo.Pull, Repo.XferHandler and Repo.ServeHTTP, and the internal/sync client, server, redirect handling and peer-address trace they use. HandleSync, HandleSyncWithOpts, Sync over a host Transport and everything else are unchanged. Without the tag nothing changes. The retry classifier keeps the two statuses it read from net/http as constants, and DNS fault classification moves to its own file so it stays in the tagged build.

  For the html-artifact-publisher engine (TinyGo 0.43.0, Go 1.26.0) the tag takes the gzipped binary from 1,100,251 to 1,003,279 bytes. A test builds the library, db and simio with the tag for the host and js/wasm and checks none links net/http, net/http/httptrace or crypto/tls, and that the untagged library still does. (user: [email protected], size: 2159) [annotate] [blame] [check-ins using] [more...]

package libfossil

import (
	"os"
	"os/exec"
	"slices"
	"strings"
	"testing"

	// The signing tests verify SSH signatures in process, which the
	// library links only for a program that imports sshverify.
	_ "github.com/danmestas/go-libfossil/sshverify"
)

// sshImportPath is the in-process SSH signature code: x/crypto/ssh and the
// ECDSA, Ed25519 and RSA implementations it links.
const sshImportPath = "golang.org/x/crypto/ssh"

// goListDeps returns the import paths of pkg's dependency closure, built for
// goos/goarch, or for the host when goos is empty.
func goListDeps(t *testing.T, goos, goarch, pkg string) []string {
	t.Helper()
	return strings.Fields(goTool(t, goos, goarch, "list", "-deps", "-f={{.ImportPath}}", pkg))
}

// goTool runs the go tool for goos/goarch, or for the host when goos is
// empty, and returns its combined output.
func goTool(t *testing.T, goos, goarch string, args ...string) string {
	t.Helper()
	cmd := exec.Command("go", args...)
	cmd.Env = os.Environ()
	if goos != "" {
		cmd.Env = append(cmd.Env, "GOOS="+goos, "GOARCH="+goarch)
	}
	out, err := cmd.CombinedOutput()
	if err != nil {
		t.Fatalf("go %s (GOOS=%q): %v\n%s", strings.Join(args, " "), goos, err, out)
	}
	return string(out)
}

// TestSSHVerifyIsOptIn: the packages an embedder links (the library, db and
// simio) carry no SSH cryptography, for the host or for js/wasm, so a
// program that never verifies an SSH signature does not carry it; the
// sshverify package links it, and the libfossil command, which verifies,
// imports it.
func TestSSHVerifyIsOptIn(t *testing.T) {
	if testing.Short() {
		t.Skip("runs the go tool")
	}
	for _, target := range [][2]string{{"", ""}, {"js", "wasm"}} {
		for _, pkg := range []string{".", "./db", "./simio"} {
			if slices.Contains(goListDeps(t, target[0], target[1], pkg), sshImportPath) {
				t.Errorf("%s (GOOS=%q) links %s; import sshverify to opt in instead",
					pkg, target[0], sshImportPath)
			}
		}
	}
	for _, pkg := range []string{"./sshverify", "./cmd/libfossil"} {
		if !slices.Contains(goListDeps(t, "", "", pkg), sshImportPath) {
			t.Errorf("%s does not link %s", pkg, sshImportPath)
		}
	}
}