Artifact [23965dd93e]

Artifact 23965dd93e689af695b368cef179ad35340f8c96d2935e8e81c6555e742fcb70:

• File conformance/repostate_gaps_test.go — part of check-in [d5fdd30d12] at 2026-10-12 00:08:35 on branch main — fix(manifest): make root check-in mlink derivation idempotent (#294) (#325)

  * fix(manifest): make root check-in mlink derivation idempotent (#294)

  The root-file branch of insertCheckinMlinks inserts each file row with no already-derived guard, unlike addMlink's pmid>0 early-out, so crosslinking a root a second time -- which the relink path does after clearing event and tagxref -- inserted a second copy of every row. Skip the block when a root row (pmid=0) is already present, matching the idempotence of fossil's manifest_crosslink.

  * test(manifest): root check-in mlink derivation is idempotent on relink (#294) (user: [email protected], size: 2906) [annotate] [blame] [check-ins using]

package conformance

import "testing"

// repostateGaps marks the repository-state cases go-libfossil is known to
// fail, by case ID, grouped by the code at fault, each with the issue
// tracking its fix.
var repostateGaps = map[string]string{
	// verify.Rebuild derives only check-ins and control artifacts: no
	// cluster tag, no technote tags (verify/rebuild_tags.go:47, :65); it
	// applies a control artifact the crosslink would refuse, having no
	// isArtifact gate (:56-70); it skips an absent tag target and an absent
	// parent rather than making a phantom (:124, rebuild_manifest.go:114); it
	// writes no plink baseline (rebuild_manifest.go:131); and its leaf rule
	// is "no child at all", whatever the branch (rebuild_leaves.go:16-21).
	"repostate.4.2.cluster.rebuild":           "#285",
	"repostate.4.2.technote-tags.rebuild":     "#285",
	"repostate.4.4.opaque-control.rebuild":    "#285",
	"repostate.4.2.phantom-target.rebuild":    "#285",
	"repostate.4.2.phantom-parent.rebuild":    "#285",
	"repostate.3.1.link-metadata.rebuild":     "#285",
	"repostate.7.2.branch-leaves.rebuild":     "#285",
	"repostate.7.6.retag-branch.rebuild":      "#285",
	"repostate.7.6.propagated-branch.rebuild": "#285",
	// No parent (reparent) tag handling in the crosslink, tag or rebuild
	// code: plink keeps the old parent.
	"repostate.4.2.reparent":         "#286",
	"repostate.4.2.reparent.rebuild": "#286",
	// isArtifact accepts a technote with a T-card naming another artifact
	// (internal/manifest/crosslink.go:583), and crosslinkEvent applies it
	// (:1510).
	"repostate.12.technote-non-self": "#287",
	// The cancel walk deletes an inherited row whatever its mtime: the query
	// is COALESCE(srcid=0, 0), without AND tagxref.mtime < ? (tag/propagate.go:67).
	"repostate.5.4.cancel-skips-newer-inherited": "#288",
	// Repo.Tag stores the name as given: no sym- prefix, no refusal of the
	// reserved wiki-, tkt- and event- prefixes (repo_extras.go:39-46,
	// internal/tag/tag.go:45).
	"repostate.2.sym-prefix":      "#293",
	"repostate.2.reserved-prefix": "#293",
}

// repostateDeviations marks the cases where go-libfossil follows fossil(1)
// rather than the draft text, by case ID.
var repostateDeviations = map[string]string{
	"repostate.7.3.parentless-untagged": "follows fossil(1): an untagged parentless " +
		"check-in is never a leaf, where Section 7.3 makes every check-in without a " +
		"same-branch child one (erratum candidate)",
}

// TestRepoStateGapKeys checks that every marked case exists.
func TestRepoStateGapKeys(t *testing.T) {
	ids := map[string]bool{}
	for _, c := range repostateSuiteCases() {
		ids[c.ID] = true
	}
	for id := range repostateGaps {
		if !ids[id] {
			t.Errorf("repostateGaps names %s, which is not a case", id)
		}
	}
	for id := range repostateDeviations {
		if !ids[id] {
			t.Errorf("repostateDeviations names %s, which is not a case", id)
		}
	}
}