| Comment: | feat(notify): add NewServiceFromPath constructor (#129)
Adds a path-based Service constructor for callers that want notify without managing the *libfossil.Repo lifecycle separately: type ServiceFromPathConfig struct { RepoPath string NATSConn *nats.Conn From string FromName string } func NewServiceFromPath(cfg ServiceFromPathConfig) (*Service, error) If the repo already exists at RepoPath it's opened; otherwise it's created via InitNotifyRepo. Service.Close() now closes the repo when the Service was constructed via NewServiceFromPath; the existing NewService path is unchanged (caller still owns the repo). The new constructor uses the same open-or-create pattern hub.NewHub uses, so re-entry on an existing path Just Works. Closes #115 |
|---|---|
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA3-256: |
5ceb63c7014886b856cd079ededf3b05 |
| User & Date: | [email protected] on 2026-05-04 20:20:08.000 |
| Other Links: | manifest | tags |
|
2026-05-04
| ||
| 20:26 |
ci(bump-upstream): walk every go.mod in the repo (#132)
The auto-generated upstream-bump PR for libfossil v0.5.0 (#121) only updated the root go.mod. leaf/go.mod and bridge/go.mod independently pin libfossil and stayed on v0.4.5 until I extended the PR by hand. Walk every go.mod file in the repo, skip ones that don't depend on the target module (so go get doesn't add it as a new dep), then run go get + go mod tidy in each. Verify-build and the git-add for the commit also iterate the same set. The find-based discovery automatically picks up future modules — when the hub package is promoted to its own go.mod (#118) or any other new module is added, no workflow change is needed. Verified by dry-running the find/grep logic locally against this repo's main: correctly identifies ./, leaf/, bridge/ as libfossil dependants and skips ./docs/site/ (Hugo site, no libfossil). Closes #127 check-in: adb39a9af9 user: [email protected] tags: trunk | |
| 20:21 |
ci(bump-upstream): walk every go.mod in the repo
The auto-generated upstream-bump PR for libfossil v0.5.0 (#121) only updated the root go.mod. leaf/go.mod and bridge/go.mod independently pin libfossil and stayed on v0.4.5 until I extended the PR by hand. Walk every go.mod file in the repo, skip ones that don't depend on the target module (so go get doesn't add it as a new dep), then run go get + go mod tidy in each. Verify-build and the git-add for the commit also iterate the same set. The find-based discovery automatically picks up future modules — when the hub package is promoted to its own go.mod (#118) or any other new module is added, no workflow change is needed. Verified by dry-running the find/grep logic locally against this repo's main: correctly identifies ./, leaf/, bridge/ as libfossil dependants and skips ./docs/site/ (Hugo site, no libfossil). Closes #127 leaf check-in: a6d596273d user: [email protected] tags: trunk, feat/127-bump-walk-all-gomods | |
| 20:20 |
feat(notify): add NewServiceFromPath constructor (#129)
Adds a path-based Service constructor for callers that want notify without managing the *libfossil.Repo lifecycle separately: type ServiceFromPathConfig struct { RepoPath string NATSConn *nats.Conn From string FromName string } func NewServiceFromPath(cfg ServiceFromPathConfig) (*Service, error) If the repo already exists at RepoPath it's opened; otherwise it's created via InitNotifyRepo. Service.Close() now closes the repo when the Service was constructed via NewServiceFromPath; the existing NewService path is unchanged (caller still owns the repo). The new constructor uses the same open-or-create pattern hub.NewHub uses, so re-entry on an existing path Just Works. Closes #115 check-in: 5ceb63c701 user: [email protected] tags: trunk | |
| 20:19 |
docs(architecture): add hub-package.md ADR (#128)
Documents the top-level hub/ package shipped in PR #109 + revised in PR #122 (deadlock fix). Covers public API surface, lifecycle ordering (HTTP listener bound during NewHub for immediate HTTPAddr availability, then NATS server ReadyForConnections), the SQLite tuning decision (busy_timeout yes, MaxOpenConns(1) explicitly no — see #120), the in-root vs. separate- module choice (with #118 as the migration path), and integration with the leaf agent (sim/hub_leaf_test.go::TestHubLeafE2E locks the contract). Cross-referenced from agent-deployment.md and listed at the top of CLAUDE.md alongside the other ADRs. Closes #114 check-in: afa1002be5 user: [email protected] tags: trunk | |